Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: make RETRY_DEAD_THRESHOLD bigger and configurable #3551

Merged
merged 9 commits into from
Mar 15, 2021
Merged

optimize: make RETRY_DEAD_THRESHOLD bigger and configurable #3551

merged 9 commits into from
Mar 15, 2021

Conversation

caohdgege
Copy link
Contributor

@caohdgege caohdgege commented Feb 26, 2021 •
edited

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3547

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 26, 2021 •
edited

Codecov Report

Merging #3551 (3c0a5db) into develop (da31cf1) will decrease coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3551      +/-   ##
=============================================
- Coverage      51.93%   51.82%   -0.12%     
  Complexity      3481     3481              
=============================================
  Files            637      637              
  Lines          21073    21074       +1     
  Branches        2610     2579      -31     
=============================================
- Hits           10944    10921      -23     
  Misses          9046     9046              
- Partials        1083     1107      +24
Impacted Files Coverage Δ Complexity Δ
...n/src/main/java/io/seata/common/DefaultValues.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/io/seata/core/constants/ConfigurationKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 83.04% <66.66%> (+0.14%) 75.00 <0.00> (ø)
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0.00%> (-4.77%) 3.00% <0.00%> (ø%)
... and 16 more

funky-eyes
funky-eyes approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caohdgege
Merge branch 'github-develop' into optimize-rollbacking
4fbf543 
# Conflicts:
#	changes/1.5.0.md
#	changes/en-us/1.5.0.md
#	server/src/main/java/io/seata/server/session/GlobalSession.java
@caohdgege
conflict
187dfbf
@caohdgege
rename
8eb7426
@caohdgege caohdgege changed the title optimize: make ROLLBACKING_RETRY_DEAD_THRESHOLD bigger and configurable optimize: make RETRY_DEAD_THRESHOLD bigger and configurable Mar 11, 2021
@xingfudeshi xingfudeshi self-requested a review March 15, 2021 01:21
xingfudeshi
xingfudeshi approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 1d888b9 into apache:develop Mar 15, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.2
4 participants
@caohdgege @codecov-io @funky-eyes @xingfudeshi