Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: do not call setBlob to invalid the jdbc exception #3555

Merged
merged 6 commits into from
Mar 6, 2021

Conversation

caohdgege
Copy link
Contributor

Ⅰ. Describe what this PR did

使用setBytes代替setBlob,避免shardingjdbc 转成setObject,再由jdbc驱动调用toString导致插入的数据被修改

Ⅱ. Does this pull request fix one issue?

fixes #3541

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #3555 (da4350c) into develop (3d87b00) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3555   +/-   ##
==========================================
  Coverage      51.96%   51.96%           
+ Complexity      3482     3479    -3     
==========================================
  Files            637      637           
  Lines          21065    21053   -12     
  Branches        2610     2606    -4     
==========================================
- Hits           10947    10941    -6     
+ Misses          9036     9031    -5     
+ Partials        1082     1081    -1     
Impacted Files Coverage Δ Complexity Δ
...seata/rm/datasource/undo/AbstractUndoExecutor.java 66.90% <0.00%> (ø) 27.00 <0.00> (ø)
...m/datasource/undo/oracle/OracleUndoLogManager.java 9.37% <0.00%> (+0.28%) 1.00 <0.00> (ø)
.../rm/datasource/undo/mysql/MySQLUndoLogManager.java 68.75% <100.00%> (ø) 6.00 <0.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)
.../saga/statelang/parser/impl/JacksonJsonParser.java 51.85% <0.00%> (+4.97%) 4.00% <0.00%> (-1.00%) ⬆️
...ata/saga/statelang/parser/impl/FastjsonParser.java 50.00% <0.00%> (+6.25%) 4.00% <0.00%> (-1.00%) ⬆️

@caohdgege caohdgege closed this Mar 5, 2021
@caohdgege caohdgege reopened this Mar 5, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata is not compatible with mysql-connector 8.0.22 when using shardingjdbc
5 participants