Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: DataSourceProxyHolder#putDataSource deadlock #3568

Merged
merged 5 commits into from
Mar 14, 2021

Conversation

spilledyear
Copy link
Contributor

#3567
修复自动数据源代理 因 ConcurrentHashMap.computeIfAbsent 导致的死锁问题

@spilledyear spilledyear changed the title bugfix: datasource proxy deadlock bugfix: DataSourceProxyHolder#putDataSource deadlock Mar 12, 2021
@codecov-io
Copy link

codecov-io commented Mar 13, 2021

Codecov Report

Merging #3568 (259132b) into develop (efefd17) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3568      +/-   ##
=============================================
- Coverage      51.95%   51.93%   -0.02%     
+ Complexity      3483     3481       -2     
=============================================
  Files            637      637              
  Lines          21066    21073       +7     
  Branches        2610     2610              
=============================================
  Hits           10944    10944              
- Misses          9039     9046       +7     
  Partials        1083     1083              
Impacted Files Coverage Δ Complexity Δ
...g/annotation/datasource/DataSourceProxyHolder.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ion/datasource/SeataAutoDataSourceProxyAdvice.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit da31cf1 into apache:develop Mar 14, 2021
0000005 pushed a commit to 0000005/seata that referenced this pull request Mar 16, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 18, 2021
@robinZhao robinZhao mentioned this pull request Apr 16, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants