feature: support the mixed use of different storages of locks and sessions #3575

funky-eyes · 2021-03-17T16:01:23Z

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…nsactions

codecov-io · 2021-03-17T16:14:23Z

Codecov Report

Merging #3575 (5ff8cb6) into develop (2dac3a5) will increase coverage by 0.00%.
The diff coverage is 56.66%.

❗ Current head 5ff8cb6 differs from pull request most recent head 14add75. Consider uploading reports for the commit 14add75 to get more accurate results

@@            Coverage Diff             @@
##             develop    #3575   +/-   ##
==========================================
  Coverage      52.12%   52.13%           
- Complexity      3502     3507    +5     
==========================================
  Files            638      638           
  Lines          21108    21134   +26     
  Branches        2618     2622    +4     
==========================================
+ Hits           11003    11018   +15     
- Misses          9016     9022    +6     
- Partials        1089     1094    +5

Impacted Files	Coverage Δ	Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
server/src/main/java/io/seata/server/Server.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...main/java/io/seata/server/env/ContainerHelper.java	`12.50% <0.00%> (-1.79%)`	`2.00 <0.00> (ø)`
...src/main/java/io/seata/server/ParameterParser.java	`47.72% <42.85%> (-2.28%)`	`11.00 <1.00> (+1.00)`	⬇️
...in/java/io/seata/server/session/SessionHolder.java	`51.90% <60.00%> (-1.27%)`	`30.00 <2.00> (ø)`
...ava/io/seata/server/lock/LockerManagerFactory.java	`75.00% <78.57%> (ø)`	`5.00 <5.00> (+3.00)`
...n/src/main/java/io/seata/common/util/IdWorker.java	`83.33% <0.00%> (+6.25%)`	`12.00% <0.00%> (+1.00%)`

caohdgege · 2021-03-19T04:24:55Z

有关于改动前后的性能测试报告吗？预期会对并发的性能有一定的提升，但是提升幅度大概是？

funky-eyes · 2021-03-19T12:00:35Z

有关于改动前后的性能测试报告吗？预期会对并发的性能有一定的提升，但是提升幅度大概是？

作为未来lock和session库的拆分的前置,未来扩展支持lock单独一个库,session单独一个库,没具体测过性能,我晚上测测看
好处就是,未来可以通过xid,把begin的tc作为发起方调用链下所有rm去注册的tc,那么session就可以完全用file存储,基于内存性能高,外部可以用redis或db存lock,保证隔离性

funky-eyes · 2021-03-19T16:26:51Z

测试demo: https://gitee.com/itCjb/spring-cloud-alibaba-seata-demo/tree/sample/
接口为testCommit
以下是200并发2000请求量秒杀同一件商品 3个微服务 1个tc
lock.mode=redis session.mode=db

Concurrency Level:      200
Time taken for tests:   105.094 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    19.03 [#/sec] (mean)
Time per request:       10509.449 [ms] (mean)
Time per request:       52.547 [ms] (mean, across all concurrent requests)
Transfer rate:          2.49 [Kbytes/sec] received

lock.mode=db session.mode=redis

Concurrency Level:      200
Time taken for tests:   119.198 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    16.78 [#/sec] (mean)
Time per request:       11919.794 [ms] (mean)
Time per request:       59.599 [ms] (mean, across all concurrent requests)
Transfer rate:          2.20 [Kbytes/sec] received

db all

Concurrency Level:      200
Time taken for tests:   138.111 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    14.48 [#/sec] (mean)
Time per request:       13811.086 [ms] (mean)
Time per request:       69.055 [ms] (mean, across all concurrent requests)
Transfer rate:          1.89 [Kbytes/sec] received

redis all

Concurrency Level:      200
Time taken for tests:   102.015 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    19.61 [#/sec] (mean)
Time per request:       10201.476 [ms] (mean)
Time per request:       51.007 [ms] (mean, across all concurrent requests)
Transfer rate:          2.57 [Kbytes/sec] received

不启用seata:

Concurrency Level:      200
Time taken for tests:   9.244 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    216.35 [#/sec] (mean)
Time per request:       924.409 [ms] (mean)
Time per request:       4.622 [ms] (mean, across all concurrent requests)
Transfer rate:          28.31 [Kbytes/sec] received

以下是200并发2000请求量随机对100件商品下单 3个微服务 1个tc
redis all

Concurrency Level:      200
Time taken for tests:   26.948 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    74.22 [#/sec] (mean)
Time per request:       2694.772 [ms] (mean)
Time per request:       13.474 [ms] (mean, across all concurrent requests)
Transfer rate:          9.71 [Kbytes/sec] received

db all

Concurrency Level:      200
Time taken for tests:   33.480 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    59.74 [#/sec] (mean)
Time per request:       3348.024 [ms] (mean)
Time per request:       16.740 [ms] (mean, across all concurrent requests)
Transfer rate:          7.82 [Kbytes/sec] received

lock.mode=redis session.mode=db

Concurrency Level:      200
Time taken for tests:   30.880 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    64.77 [#/sec] (mean)
Time per request:       3087.963 [ms] (mean)
Time per request:       15.440 [ms] (mean, across all concurrent requests)
Transfer rate:          8.48 [Kbytes/sec] received

lock.mode=db session.mode=redis

Concurrency Level:      200
Time taken for tests:   35.310 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    56.64 [#/sec] (mean)
Time per request:       3530.951 [ms] (mean)
Time per request:       17.655 [ms] (mean, across all concurrent requests)
Transfer rate:          7.41 [Kbytes/sec] received

不启用seata

Concurrency Level:      200
Time taken for tests:   8.504 seconds
Complete requests:      2000
Failed requests:        0
Total transferred:      268000 bytes
HTML transferred:       4000 bytes
Requests per second:    235.19 [#/sec] (mean)
Time per request:       850.393 [ms] (mean)
Time per request:       4.252 [ms] (mean, across all concurrent requests)
Transfer rate:          30.78 [Kbytes/sec] received

caohdgege · 2021-03-21T14:58:46Z

这个能否兼容原有的配置形式？

slievrly · 2021-03-26T09:19:00Z

script/server/config/file.conf

@@ -4,6 +4,14 @@ store {
  ## store mode: file、db、redis
  mode = "file"


It is recommended to remove this configuration item, but it is compatible with the program.

funky-eyes · 2021-03-26T15:52:44Z

这个能否兼容原有的配置形式？

兼容

slievrly

LGTM

caohdgege

@parameter(names = {"--storeMode", "-m"}, description = "log store mode : file, db", order = 3)
这个参数是否需要跟store.session.mode统一？
store.lock.mode是否需要暴露出去？

funky-eyes · 2021-03-27T12:12:22Z

@parameter(names = {"--storeMode", "-m"}, description = "log store mode : file, db", order = 3)
这个参数是否需要跟store.session.mode统一？
store.lock.mode是否需要暴露出去？

有道理,我加一下

server/src/main/java/io/seata/server/ParameterParser.java

server/src/main/java/io/seata/server/session/SessionHolder.java

server/src/main/java/io/seata/server/ParameterParser.java

codecov-commenter · 2021-05-02T09:57:37Z

Codecov Report

Merging #3575 (511b0ac) into develop (f202a07) will decrease coverage by 0.02%.
The diff coverage is 51.42%.

@@              Coverage Diff              @@
##             develop    #3575      +/-   ##
=============================================
- Coverage      51.70%   51.68%   -0.03%     
- Complexity      3518     3521       +3     
=============================================
  Files            640      640              
  Lines          21391    21420      +29     
  Branches        2670     2675       +5     
=============================================
+ Hits           11060    11070      +10     
- Misses          9229     9241      +12     
- Partials        1102     1109       +7

Impacted Files	Coverage Δ	Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...e/src/main/java/io/seata/core/store/StoreMode.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
server/src/main/java/io/seata/server/Server.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...main/java/io/seata/server/env/ContainerHelper.java	`12.50% <0.00%> (-1.79%)`	`2.00 <0.00> (ø)`
...src/main/java/io/seata/server/ParameterParser.java	`46.80% <45.45%> (-3.20%)`	`11.00 <1.00> (+1.00)`	⬇️
...ava/io/seata/server/lock/LockerManagerFactory.java	`70.58% <73.33%> (-4.42%)`	`5.00 <5.00> (+3.00)`	⬇️
...in/java/io/seata/server/session/SessionHolder.java	`53.54% <100.00%> (+0.36%)`	`30.00 <0.00> (ø)`
...n/src/main/java/io/seata/common/util/IdWorker.java	`77.08% <0.00%> (-6.25%)`	`11.00% <0.00%> (-1.00%)`

caohdgege

LGTM

xingfudeshi

LGTM.

funky-eyes added 4 commits March 17, 2021 23:31

feature: support the mixed use of different storages of locks and tra…

6a28c34

…nsactions

supplement

9dbf75a

optimize code

e642004

update

924352c

funky-eyes requested a review from slievrly March 18, 2021 13:14

Merge branch 'develop' into 0317

5b78663

funky-eyes added this to the 1.5.0 milestone Mar 18, 2021

funky-eyes requested a review from l81893521 March 18, 2021 13:33

slievrly reviewed Mar 26, 2021

View reviewed changes

optimize code

17b2322

update

637dab1

slievrly approved these changes Mar 26, 2021

View reviewed changes

caohdgege reviewed Mar 26, 2021

View reviewed changes

funky-eyes added 4 commits March 27, 2021 21:56

optimize code

343d213

Merge branch '0317' of github.com:a364176773/seata into 0317

6ae2662

optimize code

986c2ac

optimize code

5ff8cb6

caohdgege reviewed Mar 27, 2021

View reviewed changes

server/src/main/java/io/seata/server/ParameterParser.java Outdated Show resolved Hide resolved

server/src/main/java/io/seata/server/session/SessionHolder.java Outdated Show resolved Hide resolved

caohdgege reviewed Mar 27, 2021

View reviewed changes

server/src/main/java/io/seata/server/ParameterParser.java Outdated Show resolved Hide resolved

server/src/main/java/io/seata/server/ParameterParser.java Outdated Show resolved Hide resolved

server/src/main/java/io/seata/server/ParameterParser.java Show resolved Hide resolved

funky-eyes added 3 commits March 28, 2021 15:42

optimize code

101c14b

optimize code

14add75

optimize code

053bd71

slievrly removed this from the 1.4.2 milestone Mar 29, 2021

slievrly added this to the 1.5.0 milestone Mar 29, 2021

funky-eyes added module/server server module type: feature Category issues or prs related to feature request. labels Apr 30, 2021

update

05cb3cc

funky-eyes added 4 commits May 2, 2021 18:02

Update 1.5.0.md

41773eb

Update 1.5.0.md

d70852c

Update 1.5.0.md

10703b7

Update 1.5.0.md

81f6f8e

caohdgege approved these changes May 3, 2021

View reviewed changes

funky-eyes added 3 commits May 3, 2021 22:12

update

2629d57

Merge branch 'develop' of https://github.com/seata/seata into 0317

ad6f124

Merge branch 'develop' of https://github.com/seata/seata into develop

511b0ac

xingfudeshi approved these changes May 5, 2021

View reviewed changes

funky-eyes merged commit 7bd0243 into apache:develop May 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: support the mixed use of different storages of locks and sessions #3575

feature: support the mixed use of different storages of locks and sessions #3575

funky-eyes commented Mar 17, 2021

codecov-io commented Mar 17, 2021 •

edited

caohdgege commented Mar 19, 2021

funky-eyes commented Mar 19, 2021 •

edited

funky-eyes commented Mar 19, 2021 •

edited

caohdgege commented Mar 21, 2021

slievrly Mar 26, 2021

funky-eyes Mar 26, 2021

funky-eyes commented Mar 26, 2021

slievrly left a comment

caohdgege left a comment

funky-eyes commented Mar 27, 2021

codecov-commenter commented May 2, 2021 •

edited

caohdgege left a comment

xingfudeshi left a comment

		@@ -4,6 +4,14 @@ store {
		## store mode: file、db、redis
		mode = "file"

feature: support the mixed use of different storages of locks and sessions #3575

feature: support the mixed use of different storages of locks and sessions #3575

Conversation

funky-eyes commented Mar 17, 2021

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-io commented Mar 17, 2021 • edited

Codecov Report

caohdgege commented Mar 19, 2021

funky-eyes commented Mar 19, 2021 • edited

funky-eyes commented Mar 19, 2021 • edited

caohdgege commented Mar 21, 2021

slievrly Mar 26, 2021

Choose a reason for hiding this comment

funky-eyes Mar 26, 2021

Choose a reason for hiding this comment

funky-eyes commented Mar 26, 2021

slievrly left a comment

Choose a reason for hiding this comment

caohdgege left a comment

Choose a reason for hiding this comment

funky-eyes commented Mar 27, 2021

codecov-commenter commented May 2, 2021 • edited

Codecov Report

caohdgege left a comment

Choose a reason for hiding this comment

xingfudeshi left a comment

Choose a reason for hiding this comment

codecov-io commented Mar 17, 2021 •

edited

funky-eyes commented Mar 19, 2021 •

edited

funky-eyes commented Mar 19, 2021 •

edited

codecov-commenter commented May 2, 2021 •

edited