-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: datasource auto proxy #3588
Merged
funky-eyes
merged 12 commits into
apache:develop
from
selfishlover:optimize-datasource-autoProxy
May 8, 2021
Merged
optimize: datasource auto proxy #3588
funky-eyes
merged 12 commits into
apache:develop
from
selfishlover:optimize-datasource-autoProxy
May 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
requested review from
xingfudeshi and
wangliang181230
and removed request for
xingfudeshi
April 30, 2021 15:25
…nto optimize-datasource-autoProxy
Codecov Report
@@ Coverage Diff @@
## develop #3588 +/- ##
=============================================
+ Coverage 51.63% 51.88% +0.24%
- Complexity 3518 3533 +15
=============================================
Files 640 639 -1
Lines 21420 21408 -12
Branches 2671 2665 -6
=============================================
+ Hits 11061 11108 +47
+ Misses 9253 9191 -62
- Partials 1106 1109 +3
|
xingfudeshi
approved these changes
May 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
funky-eyes
added
module/seata-spring-boot-starter
seata-spring-boot-starter module
module/spring
spring module
type: optimize
labels
May 6, 2021
funky-eyes
approved these changes
May 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module/seata-spring-boot-starter
seata-spring-boot-starter module
module/spring
spring module
type: optimize
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Simplify the logic of datasource auto proxy, reduce redundant code by merging them into one processor.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Added an integration test which simulates 3 major ways how user would register their DataSource bean.
Ⅳ. Describe how to verify it
Add project's spring boot starter to your project dependency, register Datasource bean in the way you like, test GlobalLock or GlobalTransaction to see whether it works. Or just run the new integration test to verify it.
fixes #3701