Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: make LoadBalanceProperties compatible with spring-boot:2.x and above #3601

Merged
merged 7 commits into from
Apr 11, 2021
Merged

optimize: make LoadBalanceProperties compatible with spring-boot:2.x and above #3601

merged 7 commits into from
Apr 11, 2021

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Mar 31, 2021 •
edited

Ⅰ. Describe what this PR did

optimize: make LoadBalanceProperties compatible with spring-boot:2.x and above.
优化：使LoadBalanceProperties与spring-boot:2.x及以上版本兼容。

原因：springboot从2.x开始，强制要求@ConfigurationProperties的prefix属性必须使用kebab-case格式。不能使用驼峰格式。

错误信息如下：

***************************
APPLICATION FAILED TO START
***************************

Description:

Configuration property name 'seata.client.loadBalance' is not valid:

    Invalid characters: 'B'
    Bean: loadBalanceProperties
    Reason: Canonical names should be kebab-case ('-' separated), lowercase alpha-numeric characters and must start with a letter

Action:

Modify 'seata.client.loadBalance' so that it conforms to the canonical names requirements.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@wangliang181230 wangliang181230 changed the title optimize: the LoadBalanceProperties compatible with spring-boot:2.3.x optimize: the LoadBalanceProperties compatible with spring-boot:2.3.x Mar 31, 2021
@wangliang181230 wangliang181230 changed the title optimize: the LoadBalanceProperties compatible with spring-boot:2.3.x optimize: make LoadBalanceProperties compatible with spring-boot:2.3.x Mar 31, 2021
@wangliang181230 wangliang181230 changed the title optimize: make LoadBalanceProperties compatible with spring-boot:2.3.x optimize: make LoadBalanceProperties compatible with spring-boot:2.3.x and above Mar 31, 2021
@wangliang181230 wangliang181230 changed the title optimize: make LoadBalanceProperties compatible with spring-boot:2.3.x and above optimize: make LoadBalanceProperties compatible with spring-boot:2.x and above Mar 31, 2021
@wangliang181230 wangliang181230 added this to the 1.4.2 milestone Mar 31, 2021
funky-eyes
funky-eyes approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

slievrly
slievrly approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit b55d24b into apache:develop Apr 11, 2021
@wangliang181230 wangliang181230 deleted the optimize/compatibleWithSpringBoot2.3.x branch April 20, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

@l81893521 l81893521 Awaiting requested review from l81893521

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wangliang181230 @slievrly @funky-eyes