-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: asynchronous deletion after the transaction is committed #3615
optimize: asynchronous deletion after the transaction is committed #3615
Conversation
…task at commit time
…task at commit time
…task at commit time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @slievrly PTAL
Codecov Report
@@ Coverage Diff @@
## develop #3615 +/- ##
==========================================
Coverage 52.15% 52.16%
+ Complexity 3509 3508 -1
==========================================
Files 638 638
Lines 21108 21108
Branches 2613 2614 +1
==========================================
+ Hits 11009 11010 +1
Misses 9014 9014
+ Partials 1085 1084 -1
|
Codecov Report
@@ Coverage Diff @@
## develop #3615 +/- ##
==========================================
Coverage 51.68% 51.68%
- Complexity 3516 3517 +1
==========================================
Files 640 640
Lines 21391 21391
Branches 2670 2670
==========================================
+ Hits 11056 11057 +1
Misses 9231 9231
+ Partials 1104 1103 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…task at commit time
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews