Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: asynchronous deletion after the transaction is committed #3615

Merged
merged 5 commits into from
May 4, 2021

Conversation

springlayer
Copy link
Contributor

…task at commit time

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @slievrly PTAL

@funky-eyes funky-eyes added this to the 1.5.0 milestone Apr 11, 2021
@codecov-io
Copy link

codecov-io commented Apr 11, 2021

Codecov Report

Merging #3615 (fddafa5) into develop (b55d24b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3615   +/-   ##
==========================================
  Coverage      52.15%   52.16%           
+ Complexity      3509     3508    -1     
==========================================
  Files            638      638           
  Lines          21108    21108           
  Branches        2613     2614    +1     
==========================================
+ Hits           11009    11010    +1     
  Misses          9014     9014           
+ Partials        1085     1084    -1     
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/server/coordinator/DefaultCore.java 51.70% <0.00%> (+0.56%) 27.00 <0.00> (+1.00)

@springlayer springlayer changed the title bugfix: fixed global transaction conflicts with the timed supplement … optimize: optimize the asynchronous deletion after the transaction is committed Apr 12, 2021
@springlayer springlayer changed the title optimize: optimize the asynchronous deletion after the transaction is committed optimize: asynchronous deletion after the transaction is committed Apr 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #3615 (7ae625a) into develop (38226ba) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3615   +/-   ##
==========================================
  Coverage      51.68%   51.68%           
- Complexity      3516     3517    +1     
==========================================
  Files            640      640           
  Lines          21391    21391           
  Branches        2670     2670           
==========================================
+ Hits           11056    11057    +1     
  Misses          9231     9231           
+ Partials        1104     1103    -1     
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/server/coordinator/DefaultCore.java 51.70% <0.00%> (+0.56%) 27.00 <0.00> (+1.00)

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants