Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove repeat change status #3626

Merged

Conversation

caohdgege
Copy link
Contributor

Ⅰ. Describe what this PR did

移除重复changeStatus的代码

Ⅱ. Does this pull request fix one issue?

fixes #3624

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 11, 2021

Codecov Report

Merging #3626 (5e37633) into develop (aa17303) will increase coverage by 0.07%.
The diff coverage is 90.00%.

❗ Current head 5e37633 differs from pull request most recent head 133b948. Consider uploading reports for the commit 133b948 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3626      +/-   ##
=============================================
+ Coverage      52.09%   52.16%   +0.07%     
+ Complexity      3511     3508       -3     
=============================================
  Files            638      638              
  Lines          21147    21106      -41     
  Branches        2629     2613      -16     
=============================================
- Hits           11016    11010       -6     
+ Misses          9044     9013      -31     
+ Partials        1087     1083       -4     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 83.47% <80.00%> (+0.43%) 76.00 <0.00> (+1.00)
...o/seata/server/coordinator/DefaultCoordinator.java 52.58% <100.00%> (+0.02%) 28.00 <0.00> (ø)
...o/seata/rm/datasource/AbstractConnectionProxy.java 12.08% <0.00%> (-1.10%) 5.00% <0.00%> (-1.00%)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 24.64% <0.00%> (-1.05%) 13.00% <0.00%> (-1.00%)
...java/io/seata/rm/datasource/ConnectionContext.java 81.44% <0.00%> (-1.04%) 36.00% <0.00%> (-1.00%)
...torage/file/store/FileTransactionStoreManager.java 57.05% <0.00%> (-0.65%) 28.00% <0.00%> (-1.00%)
...sqlparser/druid/oracle/OracleDeleteRecognizer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...sqlparser/druid/oracle/OracleUpdateRecognizer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...r/druid/postgresql/PostgresqlDeleteRecognizer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...r/druid/postgresql/PostgresqlUpdateRecognizer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 5 more

@funky-eyes funky-eyes added this to the 1.5.0 milestone Apr 11, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM changes 1.5.0.md

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #3626 (d5f0c6e) into develop (1ab63ea) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3626      +/-   ##
=============================================
- Coverage      51.89%   51.88%   -0.01%     
+ Complexity      3533     3532       -1     
=============================================
  Files            639      639              
  Lines          21408    21406       -2     
  Branches        2665     2664       -1     
=============================================
- Hits           11109    11107       -2     
  Misses          9190     9190              
  Partials        1109     1109              
Impacted Files Coverage Δ Complexity Δ
...ata/rm/datasource/undo/AbstractUndoLogManager.java 51.42% <0.00%> (ø) 19.00 <0.00> (ø)
...in/java/io/seata/server/session/GlobalSession.java 83.04% <80.00%> (ø) 75.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 52.11% <100.00%> (-0.45%) 27.00 <0.00> (-1.00)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit c0af9c0 into apache:develop May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB&Redis模式下重复修改全局事务状态的问题
5 participants