-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: remove repeat change status #3626
optimize: remove repeat change status #3626
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3626 +/- ##
=============================================
+ Coverage 52.09% 52.16% +0.07%
+ Complexity 3511 3508 -3
=============================================
Files 638 638
Lines 21147 21106 -41
Branches 2629 2613 -16
=============================================
- Hits 11016 11010 -6
+ Misses 9044 9013 -31
+ Partials 1087 1083 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM changes 1.5.0.md
Codecov Report
@@ Coverage Diff @@
## develop #3626 +/- ##
=============================================
- Coverage 51.89% 51.88% -0.01%
+ Complexity 3533 3532 -1
=============================================
Files 639 639
Lines 21408 21406 -2
Branches 2665 2664 -1
=============================================
- Hits 11109 11107 -2
Misses 9190 9190
Partials 1109 1109
|
# Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
移除重复changeStatus的代码
Ⅱ. Does this pull request fix one issue?
fixes #3624
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews