Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: use TreeMap instead of the LinkedHashMap in TableMeta to compatible high level MySQL #3627

Merged
merged 5 commits into from
May 18, 2021

Conversation

caohdgege
Copy link
Contributor

@caohdgege caohdgege commented Apr 11, 2021

Ⅰ. Describe what this PR did

optimize: use TreeMap instead of LinkedHashMap to compatible high level MySQL

Ⅱ. Does this pull request fix one issue?

fixes #4464

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Apr 12, 2021
Copy link
Contributor

@sustly sustly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Apr 16, 2021

Codecov Report

Merging #3627 (f1f2a3d) into develop (b55d24b) will decrease coverage by 0.09%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3627      +/-   ##
=============================================
- Coverage      52.15%   52.06%   -0.10%     
- Complexity      3509     3512       +3     
=============================================
  Files            638      638              
  Lines          21108    21153      +45     
  Branches        2613     2631      +18     
=============================================
+ Hits           11009    11013       +4     
- Misses          9014     9049      +35     
- Partials        1085     1091       +6     
Impacted Files Coverage Δ Complexity Δ
...tasource/sql/struct/cache/MysqlTableMetaCache.java 80.45% <0.00%> (-1.90%) 10.00 <0.00> (ø)
...asource/sql/struct/cache/OracleTableMetaCache.java 76.47% <0.00%> (-1.85%) 10.00 <0.00> (ø)
...rce/sql/struct/cache/PostgresqlTableMetaCache.java 73.86% <0.00%> (-1.72%) 10.00 <0.00> (ø)
.../rm/datasource/exec/BaseTransactionalExecutor.java 58.77% <100.00%> (-0.46%) 27.00 <0.00> (ø)
...a/io/seata/rm/datasource/sql/struct/TableMeta.java 96.36% <100.00%> (ø) 27.00 <0.00> (ø)
...a/sqlparser/druid/mysql/MySQLDeleteRecognizer.java 66.66% <0.00%> (-14.29%) 8.00% <0.00%> (ø%)
...a/sqlparser/druid/mysql/MySQLUpdateRecognizer.java 84.00% <0.00%> (-9.34%) 15.00% <0.00%> (ø%)
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 58.82% <0.00%> (-0.80%) 11.00% <0.00%> (ø%)
...sqlparser/druid/oracle/OracleDeleteRecognizer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 6 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #3627 (006bb25) into develop (a3d3ee6) will decrease coverage by 0.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3627      +/-   ##
=============================================
- Coverage      51.30%   51.29%   -0.02%     
+ Complexity      3577     3574       -3     
=============================================
  Files            645      645              
  Lines          21808    21814       +6     
  Branches        2736     2740       +4     
=============================================
  Hits           11189    11189              
- Misses          9483     9486       +3     
- Partials        1136     1139       +3     
Impacted Files Coverage Δ Complexity Δ
.../rm/datasource/exec/BaseTransactionalExecutor.java 59.09% <0.00%> (ø) 27.00 <0.00> (ø)
...tasource/sql/struct/cache/MysqlTableMetaCache.java 81.60% <0.00%> (-1.93%) 11.00 <0.00> (ø)
...asource/sql/struct/cache/OracleTableMetaCache.java 76.47% <0.00%> (-1.85%) 10.00 <0.00> (ø)
...rce/sql/struct/cache/PostgresqlTableMetaCache.java 73.86% <0.00%> (-1.72%) 10.00 <0.00> (ø)
...a/io/seata/rm/datasource/sql/struct/TableMeta.java 96.36% <100.00%> (ø) 27.00 <0.00> (ø)

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caohdgege caohdgege changed the title optimize: use TreeMap instead of LinkedHashMap to compatible high level MySQL optimize: use TreeMap instead of the LinkedHashMap in TableMeta to compatible high level MySQL May 18, 2021
@funky-eyes funky-eyes added the module/rm-datasource rm-datasource module label May 18, 2021
@funky-eyes funky-eyes merged commit 373d538 into apache:develop May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants