-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: use TreeMap instead of the LinkedHashMap in TableMeta to compatible high level MySQL #3627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMeta.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #3627 +/- ##
=============================================
- Coverage 52.15% 52.06% -0.10%
- Complexity 3509 3512 +3
=============================================
Files 638 638
Lines 21108 21153 +45
Branches 2613 2631 +18
=============================================
+ Hits 11009 11013 +4
- Misses 9014 9049 +35
- Partials 1085 1091 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #3627 +/- ##
=============================================
- Coverage 51.30% 51.29% -0.02%
+ Complexity 3577 3574 -3
=============================================
Files 645 645
Lines 21808 21814 +6
Branches 2736 2740 +4
=============================================
Hits 11189 11189
- Misses 9483 9486 +3
- Partials 1136 1139 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
optimize: use TreeMap instead of LinkedHashMap to compatible high level MySQL
Ⅱ. Does this pull request fix one issue?
fixes #4464
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews