-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: fix typo, applicationContex to applicationContext #3654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 注:1.4.2发布后再做合并,标题以optimize: 开头 标题简洁描写pr内容是什么
Codecov Report
@@ Coverage Diff @@
## develop #3654 +/- ##
=============================================
+ Coverage 51.91% 51.92% +0.01%
Complexity 3503 3503
=============================================
Files 639 639
Lines 21181 21181
Branches 2633 2633
=============================================
+ Hits 10996 10999 +3
+ Misses 9091 9089 -2
+ Partials 1094 1093 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
请登记pr信息及个人信息到changes文件夹中的2个1.5.0.md文件中 |
冲突了,解决以下,你把其它pr里的内容拿过来了,你应该合并seata/develop分支的代码后,在进行补充 |
不好意思,我下午操作失误了。刚刚我强制回滚到了我的上次提交,然后pull rebase了seata官方仓库的develop分支,结果中间的部分提交也出现在了上面,感觉怪怪的,不知道做对了没 |
现在越来越不对了,直接回滚到之前的提交记录,git pull 官方仓库 develop即可 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
just fix typo
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
just fix typo
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews