Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize some javadocs #3664

Merged
merged 5 commits into from
Apr 23, 2021
Merged

optimize: optimize some javadocs #3664

merged 5 commits into from
Apr 23, 2021

Conversation

slievrly
Copy link
Member

Ⅰ. Describe what this PR did

optimize: optimize some javadocs
image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.4.2 milestone Apr 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2021

Codecov Report

Merging #3664 (8884670) into develop (5fac979) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3664   +/-   ##
==========================================
  Coverage      51.91%   51.91%           
  Complexity      3500     3500           
==========================================
  Files            639      639           
  Lines          21181    21181           
  Branches        2634     2634           
==========================================
  Hits           10996    10996           
  Misses          9091     9091           
  Partials        1094     1094           
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/common/util/CompressUtil.java 96.00% <ø> (ø) 7.00 <0.00> (ø)
...seata/core/exception/AbstractExceptionHandler.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../src/main/java/io/seata/core/protocol/Version.java 7.40% <ø> (ø) 2.00 <0.00> (ø)
.../main/java/io/seata/rm/datasource/ColumnUtils.java 86.59% <ø> (ø) 27.00 <0.00> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 24.64% <ø> (ø) 13.00 <0.00> (ø)
.../java/io/seata/rm/datasource/DataCompareUtils.java 74.11% <ø> (ø) 27.00 <0.00> (ø)
.../java/io/seata/rm/datasource/SqlGenerateUtils.java 95.23% <ø> (ø) 18.00 <0.00> (ø)
...o/seata/rm/datasource/exec/BaseInsertExecutor.java 71.89% <ø> (ø) 83.00 <0.00> (ø)
.../rm/datasource/exec/BaseTransactionalExecutor.java 58.77% <ø> (ø) 27.00 <0.00> (ø)
.../rm/datasource/exec/mysql/MySQLInsertExecutor.java 69.41% <ø> (ø) 16.00 <0.00> (ø)
... and 17 more

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit c091e69 into apache:develop Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants