Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support kotlin coroutine #3668

Merged
merged 35 commits into from
Sep 6, 2021
Merged

feature: support kotlin coroutine #3668

merged 35 commits into from
Sep 6, 2021

Conversation

sustly
Copy link
Contributor

@sustly sustly commented Apr 23, 2021

Ⅰ. Describe what this PR did

support kotlin coroutine,if you use kotlin coroutine, GlobalTransactional can not help you

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

1.use @GlobalTransactional
image
you can see, xid is null.
2.use transactionScope
image
test passed.

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2021

Codecov Report

Merging #3668 (86d226c) into develop (fc327b8) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3668      +/-   ##
=============================================
- Coverage      40.21%   40.17%   -0.04%     
  Complexity      3081     3081              
=============================================
  Files            690      692       +2     
  Lines          23369    23391      +22     
  Branches        2894     2900       +6     
=============================================
  Hits            9397     9397              
- Misses         13098    13120      +22     
  Partials         874      874              
Impacted Files Coverage Δ
...a/spring/kt/support/TransactionCoroutineContext.kt 0.00% <0.00%> (ø)
.../java/io/seata/spring/kt/support/TransactionDsl.kt 0.00% <0.00%> (ø)

@sustly sustly closed this Apr 23, 2021
@sustly sustly reopened this Apr 23, 2021
@sustly sustly changed the title optimize: support kotlin coroutine feature: support kotlin coroutine Apr 27, 2021
spring/pom.xml Outdated Show resolved Hide resolved
spring/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add change md

spring/pom.xml Outdated Show resolved Hide resolved
spring/pom.xml Outdated Show resolved Hide resolved
spring/pom.xml Outdated Show resolved Hide resolved
@sustly sustly requested a review from jsbxyyx August 27, 2021 08:14
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Sep 6, 2021
@funky-eyes funky-eyes merged commit ad5e933 into apache:develop Sep 6, 2021
UmmizzZ pushed a commit to UmmizzZ/seata that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants