-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support kotlin coroutine #3668
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3668 +/- ##
=============================================
- Coverage 40.21% 40.17% -0.04%
Complexity 3081 3081
=============================================
Files 690 692 +2
Lines 23369 23391 +22
Branches 2894 2900 +6
=============================================
Hits 9397 9397
- Misses 13098 13120 +22
Partials 874 874
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add change md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
support kotlin coroutine,if you use kotlin coroutine, GlobalTransactional can not help you
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
1.use @GlobalTransactional
you can see, xid is null.
2.use transactionScope
test passed.
Ⅴ. Special notes for reviews