Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the case that could not retry acquire global lock #3687

Merged
merged 9 commits into from
Apr 29, 2021

Conversation

caohdgege
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #3687 (251748d) into develop (a8e553f) will increase coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head 251748d differs from pull request most recent head 8fabef5. Consider uploading reports for the commit 8fabef5 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3687      +/-   ##
=============================================
+ Coverage      51.91%   51.92%   +0.01%     
- Complexity      3500     3503       +3     
=============================================
  Files            639      639              
  Lines          21181    21182       +1     
  Branches        2634     2634              
=============================================
+ Hits           10996    10999       +3     
+ Misses          9091     9089       -2     
  Partials        1094     1094              
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/io/seata/core/protocol/Version.java 7.40% <ø> (ø) 2.00 <0.00> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 25.69% <71.42%> (+1.04%) 14.00 <3.00> (+1.00)
...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java 58.82% <100.00%> (-0.80%) 11.00 <0.00> (ø)
...java/io/seata/rm/datasource/ConnectionContext.java 82.47% <0.00%> (+1.03%) 37.00% <0.00%> (+1.00%)
...o/seata/rm/datasource/AbstractConnectionProxy.java 13.18% <0.00%> (+1.09%) 6.00% <0.00%> (+1.00%)

@caohdgege caohdgege closed this Apr 28, 2021
@caohdgege caohdgege reopened this Apr 28, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Apr 29, 2021
@funky-eyes funky-eyes added module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug. labels Apr 29, 2021
@funky-eyes funky-eyes merged commit d4b20ec into apache:develop Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants