Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Modify the attribute prefix in the file file.properties #3689

Merged
merged 4 commits into from
Apr 30, 2021
Merged

optimize: Modify the attribute prefix in the file file.properties #3689

merged 4 commits into from
Apr 30, 2021

Conversation

ruanun
Copy link
Contributor

@ruanun ruanun commented Apr 29, 2021

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 这个是参考配置,应该是optimize: 开头,changes文件夹中2个1.5.0.md文件进行登记一下pr信息和你本人github信息

@funky-eyes funky-eyes added this to the 1.5.0 milestone Apr 29, 2021
@ruanun ruanun changed the title bugfix: Modify the attribute prefix in the file file.properties optimize: Modify the attribute prefix in the file file.properties Apr 29, 2021
@funky-eyes
Copy link
Contributor

image
本地的github绑定一下邮箱再重新推一下,否者没有你的github信息

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit c3a441c into apache:develop Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants