-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix mariadb unable to create XA connection #3695
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3695 +/- ##
==========================================
Coverage 51.31% 51.32%
- Complexity 3576 3577 +1
==========================================
Files 646 646
Lines 21809 21809
Branches 2738 2737 -1
==========================================
+ Hits 11191 11193 +2
+ Misses 9480 9479 -1
+ Partials 1138 1137 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
SpringBoot:2.4.1 测试事务可以正常使用 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
如果引入了mariadb的驱动却没有引入mysql的,那么druid的MySqlUtils只会反射mysql的驱动来创建xaconnection,此时会抛出npe,mariadb xa模式就无法正常使用
Ⅱ. Does this pull request fix one issue?
fixes #3696
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews