Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: unified the default value of enableClientBatchSendRequest #3713

Conversation

13414850431
Copy link
Contributor

Ⅰ. Describe what this PR did

unified the default value of enableClientBatchSendRequest

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #3713 (a495883) into develop (500b464) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a495883 differs from pull request most recent head 6a512d1. Consider uploading reports for the commit 6a512d1 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3713      +/-   ##
=============================================
- Coverage      51.88%   51.87%   -0.01%     
+ Complexity      3535     3532       -3     
=============================================
  Files            639      639              
  Lines          21414    21414              
  Branches        2665     2665              
=============================================
- Hits           11110    11108       -2     
  Misses          9195     9195              
- Partials        1109     1111       +2     
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 52.11% <0.00%> (-0.47%) 27.00% <0.00%> (-2.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.04% <0.00%> (-0.44%) 75.00% <0.00%> (-1.00%)

@13414850431 13414850431 changed the title optimize: unified the default value of enableClientBatchSendRequest unified the default value of enableClientBatchSendRequest May 9, 2021
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@13414850431 13414850431 changed the title unified the default value of enableClientBatchSendRequest optimize:unified the default value of enableClientBatchSendRequest May 9, 2021
changes/en-us/1.5.0.md Outdated Show resolved Hide resolved
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title optimize:unified the default value of enableClientBatchSendRequest optimize: unified the default value of enableClientBatchSendRequest May 9, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone May 9, 2021
@funky-eyes funky-eyes added the module/script script module label May 9, 2021
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit b7b674e into apache:develop May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/script script module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants