Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix the problem in the findTargetClass method #3716

Merged
merged 4 commits into from
May 11, 2021

Conversation

ls9527
Copy link
Contributor

@ls9527 ls9527 commented May 10, 2021

Ⅰ. Describe what this PR did

修复获取代理对象类型时, 由于未判断静态类型引起的spring-security框架结合是无法启动的问题

Ⅱ. Does this pull request fix one issue?

fixes #3709

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

在官方提供的例子中
seata-samples->sprngboot-mybatis-sbm-sorage-service项目中
加入maven引用

        <dependency>
            <groupId>org.springframework.security.oauth</groupId>
            <artifactId>spring-security-oauth2</artifactId>
            <version>2.2.0.RELEASE</version>
        </dependency>

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-security</artifactId>
            <version>2.2.0.RELEASE</version>
        </dependency>

在启动类的Application类上加入注解 @EnableOAuth2Client

在1.4.2版本下就可以重现#issue 3709的问题。

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #3716 (83317ea) into develop (b7b674e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 83317ea differs from pull request most recent head 6200cf3. Consider uploading reports for the commit 6200cf3 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3716      +/-   ##
=============================================
- Coverage      51.88%   51.87%   -0.01%     
- Complexity      3533     3534       +1     
=============================================
  Files            639      639              
  Lines          21414    21416       +2     
  Branches        2665     2666       +1     
=============================================
- Hits           11111    11110       -1     
- Misses          9193     9197       +4     
+ Partials        1110     1109       -1     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/spring/util/SpringProxyUtils.java 3.70% <0.00%> (-0.15%) 3.00 <0.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.47% <0.00%> (+0.43%) 76.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 52.58% <0.00%> (+0.46%) 28.00% <0.00%> (+1.00%)

@xingfudeshi xingfudeshi changed the title 修复获取代理对象类型时, 由于未判断静态类型引起的spring-security框架结合是无法启动的问题 bugfix:fix the problem in the findTargetClass method May 10, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 请在changes文件夹中登记此pr及作者信息到两个1.5.0md中

@funky-eyes funky-eyes added this to the 1.5.0 milestone May 10, 2021
@funky-eyes funky-eyes added module/spring spring module type: bug Category issues or prs related to bug. labels May 10, 2021
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/spring spring module type: bug Category issues or prs related to bug.
Projects
None yet
4 participants