Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: the basic code of distributed lock #3722

Merged
merged 10 commits into from
May 13, 2021
Merged

optimize: the basic code of distributed lock #3722

merged 10 commits into from
May 13, 2021

Conversation

lightClouds917
Copy link
Contributor

Ⅰ. Describe what this PR did

add the basic code of distributed lock,to support the mysql /redis distributed lock

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #3722 (866893b) into develop (e684e6b) will increase coverage by 0.52%.
The diff coverage is 16.66%.

❗ Current head 866893b differs from pull request most recent head 44011e2. Consider uploading reports for the commit 44011e2 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3722      +/-   ##
=============================================
+ Coverage      51.33%   51.85%   +0.52%     
+ Complexity      3575     3535      -40     
=============================================
  Files            645      640       -5     
  Lines          21798    21425     -373     
  Branches        2737     2665      -72     
=============================================
- Hits           11190    11111      -79     
+ Misses          9468     9205     -263     
+ Partials        1140     1109      -31     
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/io/seata/core/store/DistributedLockDO.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
common/src/main/java/io/seata/common/XID.java 92.30% <100.00%> (+0.64%) 8.00 <2.00> (+1.00)
...source/AbstractDataSourceCacheResourceManager.java 42.85% <0.00%> (-42.86%) 1.00% <0.00%> (-1.00%)
...ource/sql/struct/cache/AbstractTableMetaCache.java 72.41% <0.00%> (-17.25%) 8.00% <0.00%> (-1.00%)
...ava/io/seata/server/metrics/MetricsSubscriber.java 72.58% <0.00%> (-6.46%) 6.00% <0.00%> (-1.00%)
...erver/storage/file/session/FileSessionManager.java 51.82% <0.00%> (-5.11%) 26.00% <0.00%> (-1.00%)
.../main/java/io/seata/rm/BaseDataSourceResource.java 26.41% <0.00%> (-3.78%) 9.00% <0.00%> (-2.00%)
...java/io/seata/spring/tcc/TccActionInterceptor.java 11.76% <0.00%> (-1.45%) 2.00% <0.00%> (ø%)
...tasource/sql/struct/cache/MysqlTableMetaCache.java 82.35% <0.00%> (-1.18%) 10.00% <0.00%> (-1.00%)
... and 31 more

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone May 13, 2021
@funky-eyes funky-eyes added closed: declined A suggestion or change that we don't feel we should currently apply module/server server module type: optimize and removed closed: declined A suggestion or change that we don't feel we should currently apply labels May 13, 2021
@funky-eyes funky-eyes changed the title add:the basic code of distributed lock optimize: the basic code of distributed lock May 13, 2021
@caohdgege caohdgege merged commit 69d1297 into apache:develop May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants