-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: do not load LoadBalance
if not necessary
#3735
Merged
funky-eyes
merged 6 commits into
apache:develop
from
wangliang181230:optimize/before-load-balance
May 18, 2021
Merged
optimize: do not load LoadBalance
if not necessary
#3735
funky-eyes
merged 6 commits into
apache:develop
from
wangliang181230:optimize/before-load-balance
May 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3735 +/- ##
=============================================
- Coverage 51.33% 51.32% -0.02%
+ Complexity 3578 3575 -3
=============================================
Files 646 645 -1
Lines 21809 21808 -1
Branches 2737 2737
=============================================
- Hits 11196 11192 -4
- Misses 9477 9481 +4
+ Partials 1136 1135 -1
|
funky-eyes
approved these changes
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
caohdgege
approved these changes
May 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangliang181230
changed the title
optimize: skip load balance if not needed
optimize: Do not load May 18, 2021
LoadBalance
if not necessary
caohdgege
changed the title
optimize: Do not load
optimize: Do not load LB if not necessary
May 18, 2021
LoadBalance
if not necessary
caohdgege
changed the title
optimize: Do not load LB if not necessary
optimize: do not load May 18, 2021
LoadBalance
if not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: Do not load
LoadBalance
if not necessary.优化:当负载均衡不需要时,不加载它。
优化的原因:
部分用户的系统本来不大,单个seata服务就够用了。这时候跳过获取负载均衡器,性能也会好一些。
最主要的是,即使负载均衡的配置错误,也不会影响这部分用户的项目启动。
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews