bugfix: fix that LocalThread is not cleared when the Saga transaction ends
#3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…achine instance failed
…a-un-clear-branch-type # Conflicts: # saga/seata-saga-engine/src/main/java/io/seata/saga/engine/sequence/SpringJvmUUIDSeqGenerator.java
…aga-un-clear-branch-type # Conflicts: # saga/seata-saga-engine-store/src/main/java/io/seata/saga/engine/store/db/DbAndReportTcStateLogStore.java
wangliang181230
changed the title
LocalThread is not cleared when the Saga transaction endsLocalThread is not cleared when the Saga transaction ends in some cases
Codecov Report
@@ Coverage Diff @@
## develop #3740 +/- ##
==========================================
Coverage 40.82% 40.82%
Complexity 2945 2945
==========================================
Files 663 663
Lines 22261 22261
Branches 2758 2758
==========================================
Hits 9089 9089
Misses 12326 12326
Partials 846 846 |
wangliang181230
commented
May 18, 2021
...seata-saga-engine/src/main/java/io/seata/saga/engine/impl/ProcessCtrlStateMachineEngine.java
Show resolved
Hide resolved
slievrly
changed the title
LocalThread is not cleared when the Saga transaction ends in some casesLocalThread is not cleared when the Saga transaction ends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
bugfix: fix that
LocalThreadis not cleared when theSagatransaction ends in some cases.错误修复：修复在某些情况下，当
Saga事务结束时LocalThread未被清除的问题。Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews