Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Transfer the operation of adding configuration class from 'AutoConfiguration' to 'EnvironmentPostProcessor' #3765

Merged

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented May 25, 2021

optimize: Transfer the operation of adding configuration class from 'AutoConfiguration' to 'EnvironmentPostProcessor'.

优化:将 添加配置类的操作AutoConfiguration转移到EnvironmentPostProcessor中。
提升该操作的优先级,避免Bean加载了,配置类却还没有添加进去,导致读取配置异常。

…AutoConfiguration' to 'EnvironmentPostProcessor'
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #3765 (80ea35f) into develop (647e846) will decrease coverage by 0.00%.
The diff coverage is 10.00%.

❗ Current head 80ea35f differs from pull request most recent head 826d171. Consider uploading reports for the commit 826d171 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3765      +/-   ##
=============================================
- Coverage      40.37%   40.36%   -0.01%     
- Complexity      3070     3071       +1     
=============================================
  Files            685      686       +1     
  Lines          23194    23201       +7     
  Branches        2869     2868       -1     
=============================================
+ Hits            9364     9366       +2     
- Misses         12960    12967       +7     
+ Partials         870      868       -2     
Impacted Files Coverage Δ
...configure/SeataClientEnvironmentPostProcessor.java 0.00% <0.00%> (ø)
.../autoconfigure/SeataTCCFenceAutoConfiguration.java 0.00% <ø> (ø)
...boot/autoconfigure/SeataCoreAutoConfiguration.java 0.00% <0.00%> (ø)
...toconfigure/SeataCoreEnvironmentPostProcessor.java 0.00% <0.00%> (ø)
...configure/SeataServerEnvironmentPostProcessor.java 0.00% <0.00%> (ø)
...ing/boot/autoconfigure/SeataAutoConfiguration.java 0.00% <ø> (ø)
...utoconfigure/SeataDataSourceAutoConfiguration.java 0.00% <ø> (ø)
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 13.63% <16.66%> (-0.94%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

@wangliang181230 wangliang181230 added this to the 1.5.0 milestone May 25, 2021
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly added the module/config config module label Jul 15, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 4dd9f69 into apache:develop Aug 20, 2021
UmmizzZ pushed a commit to UmmizzZ/seata that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/config config module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants