Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: close the Closeable and optimize some code #3770

Merged

Conversation

wangliang181230
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize: close the Closeable and optimize some code.
优化:关闭一些未关闭的对象。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@wangliang181230 wangliang181230 added this to the 1.5.0 milestone May 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3770 (c9565ab) into develop (a361fba) will increase coverage by 0.01%.
The diff coverage is 45.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3770      +/-   ##
=============================================
+ Coverage      40.82%   40.84%   +0.01%     
- Complexity      2945     2947       +2     
=============================================
  Files            663      663              
  Lines          22261    22260       -1     
  Branches        2758     2754       -4     
=============================================
+ Hits            9089     9091       +2     
  Misses         12326    12326              
+ Partials         846      843       -3     
Impacted Files Coverage Δ
...o/seata/rm/datasource/exec/BaseInsertExecutor.java 71.12% <0.00%> (-0.77%) ⬇️
...source/exec/mysql/MySQLInsertOrUpdateExecutor.java 31.46% <0.00%> (ø)
...torage/file/store/FileTransactionStoreManager.java 0.00% <ø> (ø)
...main/java/io/seata/config/file/YamlFileConfig.java 65.00% <100.00%> (+1.84%) ⬆️
...m/datasource/undo/parser/JacksonUndoLogParser.java 69.01% <100.00%> (+0.21%) ⬆️
...col/transaction/AbstractBranchEndRequestCodec.java 57.74% <100.00%> (ø)
...otocol/transaction/BranchRegisterRequestCodec.java 72.13% <100.00%> (+2.28%) ⬆️
...protocol/transaction/BranchReportRequestCodec.java 75.92% <100.00%> (+1.38%) ⬆️
... and 1 more

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 5d638ab into apache:develop May 27, 2021
@wangliang181230 wangliang181230 deleted the optimize/close-the-Closeable branch May 27, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants