Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: consul not found tc cluster #3773

Merged
merged 2 commits into from
May 28, 2021
Merged

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3772

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #3773 (c9b3887) into develop (5d638ab) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3773   +/-   ##
==========================================
  Coverage      40.85%   40.85%           
  Complexity      2946     2946           
==========================================
  Files            663      663           
  Lines          22260    22260           
  Branches        2755     2755           
==========================================
  Hits            9094     9094           
  Misses         12324    12324           
  Partials         842      842           
Impacted Files Coverage Δ
...ery/registry/consul/ConsulRegistryServiceImpl.java 1.76% <0.00%> (ø)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 17d298c into apache:develop May 28, 2021
iqinning pushed a commit to iswift-cloud/seata that referenced this pull request May 31, 2021
@slievrly slievrly added this to the 1.5.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants