-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: consul not found tc cluster #3773
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3773 +/- ##
==========================================
Coverage 40.85% 40.85%
Complexity 2946 2946
==========================================
Files 663 663
Lines 22260 22260
Branches 2755 2755
==========================================
Hits 9094 9094
Misses 12324 12324
Partials 842 842
|
...overy-consul/src/main/java/io/seata/discovery/registry/consul/ConsulRegistryServiceImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #3772
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews