Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the problem that 'store mode' parameter does not take effect #3783

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

objcoding
Copy link
Contributor

Ⅰ. Describe what this PR did

After the original store mode is split into session store mode and lock store mode, after old users upgrade to the new version, the store mode in the upgraded system will become invalid.
Solution:

  1. Remove the default values of session store mode and lock store mode;
  2. The store mode is reserved as a global setting.

This will make seata better compatible with the old version and more user-friendly upgrades.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2021

Codecov Report

Merging #3783 (420e7f2) into develop (8f62e9c) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3783      +/-   ##
=============================================
- Coverage      40.86%   40.84%   -0.02%     
+ Complexity      2956     2955       -1     
=============================================
  Files            662      662              
  Lines          22310    22308       -2     
  Branches        2777     2777              
=============================================
- Hits            9116     9111       -5     
- Misses         12347    12349       +2     
- Partials         847      848       +1     
Impacted Files Coverage Δ
...igure/properties/server/store/StoreProperties.java 35.29% <ø> (-6.82%) ⬇️
...src/main/java/io/seata/server/ParameterParser.java 0.00% <ø> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone May 30, 2021
@funky-eyes funky-eyes added module/server server module type: bug Category issues or prs related to bug. labels May 30, 2021
@wangliang181230 wangliang181230 changed the title bugfix:fix the problem that 'store mode' parameter does not take effect. bugfix: fix the problem that 'store mode' parameter does not take effect Jun 1, 2021
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 merged commit d9ed080 into apache:develop Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants