optimize: optimize zk registry lookup performance #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
登记一下pr和作者信息到changes文件夹中2个的1.5.0.md中 |
funky-eyes
requested changes
Jun 2, 2021
...-discovery-zk/src/main/java/io/seata/discovery/registry/zk/ZookeeperRegisterServiceImpl.java
Outdated
Show resolved
Hide resolved
...-discovery-zk/src/main/java/io/seata/discovery/registry/zk/ZookeeperRegisterServiceImpl.java
Show resolved
Hide resolved
iqinning
force-pushed
the
optimize-zk-registry-performance
branch
from
40868fe
to
170c450
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3795 +/- ##
==========================================
Coverage 40.84% 40.84%
- Complexity 2955 2956 +1
==========================================
Files 662 662
Lines 22308 22312 +4
Branches 2777 2777
==========================================
+ Hits 9111 9114 +3
Misses 12349 12349
- Partials 848 849 +1
|
iqinning
force-pushed
the
optimize-zk-registry-performance
branch
from
170c450
to
2318c8c
Compare
iqinning
force-pushed
the
optimize-zk-registry-performance
branch
from
2318c8c
to
c4fb4d1
Compare
funky-eyes
reviewed
Jun 2, 2021
...-discovery-zk/src/main/java/io/seata/discovery/registry/zk/ZookeeperRegisterServiceImpl.java
Show resolved
Hide resolved
funky-eyes
added
first-time contributor
funky-eyes
requested review from
wangliang181230,
slievrly,
caohdgege and
l81893521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: optimize zk registry lookup performance
see detail #3498
Ⅱ. Does this pull request fix one issue?
fixes #3498
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews