-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: support instance BusinessActionContext
outside the TCC try method
#3797
optimize: support instance BusinessActionContext
outside the TCC try method
#3797
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3797 +/- ##
=============================================
+ Coverage 40.65% 40.71% +0.06%
- Complexity 3032 3042 +10
=============================================
Files 677 679 +2
Lines 22745 22779 +34
Branches 2831 2841 +10
=============================================
+ Hits 9247 9275 +28
- Misses 12633 12634 +1
- Partials 865 870 +5
|
common/src/test/java/io/seata/common/util/ReflectionUtilTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
请解决一下冲突 |
…-method # Conflicts: # tcc/src/main/java/io/seata/rm/tcc/TCCResourceManager.java # tcc/src/main/java/io/seata/rm/tcc/interceptor/ActionInterceptorHandler.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
optimize: support instance
BusinessActionContext
outside the TCC try method.一)使用方式增强:
Try
方法外,由用户自己实例化BusinessActionContext
,再以Try
方法入参的形式传入。二)其他优化:
SkipCallbackWrapperException
,使语义更加容易理解。isShardingParam
标记为已过期,这个属性从TCC模式引入seata到现在还没有用到过。StringUtils.toString(Object obj)
方法。