Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: support instance BusinessActionContext outside the TCC try method #3797

Merged
merged 23 commits into from
Jul 15, 2021

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Jun 2, 2021

optimize: support instance BusinessActionContext outside the TCC try method.


一)使用方式增强:

  1. 支持在Try 方法外,由用户自己实例化BusinessActionContext,再以Try方法入参的形式传入。

二)其他优化:

  1. 添加异常类SkipCallbackWrapperException,使语义更加容易理解。
  2. TCC注解的属性isShardingParam标记为已过期,这个属性从TCC模式引入seata到现在还没有用到过。
  3. 其他一些注释或参数名调整。
  4. 优化StringUtils.toString(Object obj)方法。

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2021

Codecov Report

Merging #3797 (43cd664) into develop (e73ad9e) will increase coverage by 0.06%.
The diff coverage is 38.04%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3797      +/-   ##
=============================================
+ Coverage      40.65%   40.71%   +0.06%     
- Complexity      3032     3042      +10     
=============================================
  Files            677      679       +2     
  Lines          22745    22779      +34     
  Branches        2831     2841      +10     
=============================================
+ Hits            9247     9275      +28     
- Misses         12633    12634       +1     
- Partials         865      870       +5     
Impacted Files Coverage Δ
...common/exception/SkipCallbackWrapperException.java 0.00% <0.00%> (ø)
...src/main/java/io/seata/rm/tcc/TCCFenceHandler.java 0.00% <0.00%> (ø)
.../main/java/io/seata/rm/tcc/TCCResourceManager.java 0.00% <0.00%> (ø)
...a/rm/tcc/interceptor/ActionInterceptorHandler.java 12.04% <4.16%> (-1.85%) ⬇️
...io/seata/rm/tcc/interceptor/ActionContextUtil.java 34.40% <39.28%> (-2.95%) ⬇️
...ain/java/io/seata/common/util/CollectionUtils.java 91.17% <66.66%> (-0.83%) ⬇️
...rc/main/java/io/seata/common/util/StringUtils.java 33.92% <72.22%> (+5.28%) ⬆️
...c/src/main/java/io/seata/rm/tcc/api/ParamType.java 85.71% <85.71%> (ø)
...main/java/io/seata/common/util/ReflectionUtil.java 59.71% <100.00%> (ø)
.../rm/tcc/remoting/parser/DefaultRemotingParser.java 23.80% <100.00%> (ø)
... and 5 more

@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Jun 2, 2021
@wangliang181230 wangliang181230 added the mode: TCC TCC transaction mode label Jun 2, 2021
Copy link
Contributor

@tanzzj tanzzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caohdgege
Copy link
Contributor

请解决一下冲突

…-method

# Conflicts:
#	tcc/src/main/java/io/seata/rm/tcc/TCCResourceManager.java
#	tcc/src/main/java/io/seata/rm/tcc/interceptor/ActionInterceptorHandler.java
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 0f92415 into apache:develop Jul 15, 2021
@wangliang181230 wangliang181230 deleted the optimize/tcc-try-method branch July 15, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: TCC TCC transaction mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants