Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: TC SkyWalking topo calling node not gather #3817

Merged
merged 5 commits into from
Jun 25, 2021
Merged

bugfix: TC SkyWalking topo calling node not gather #3817

merged 5 commits into from
Jun 25, 2021

Conversation

zhaoyuguang
Copy link
Member

fixed #3810

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021 •
edited

Codecov Report

Merging #3817 (7e813dc) into develop (647c309) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3817      +/-   ##
=============================================
- Coverage      40.83%   40.82%   -0.02%     
+ Complexity      2985     2984       -1     
=============================================
  Files            667      667              
  Lines          22507    22507              
  Branches        2800     2800              
=============================================
- Hits            9191     9188       -3     
- Misses         12469    12471       +2     
- Partials         847      848       +1
Impacted Files Coverage Δ
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️

@caohdgege
Copy link
Contributor

caohdgege commented Jun 14, 2021 •
edited

image

It seems the newest topo is not expect. the node seata_tc & 127.0.0.1:8091 is the same node.

@zhaoyuguang
Copy link
Member Author

image

It seems the newest topo is not expect. the node seata_tc & 127.0.0.1:8091 is the same node.

If use such as Chrome, go to developer mode, copy HTTP Response, let us check the env is wrong

@caohdgege
Copy link
Contributor

image

It seems ok after swtich to newest agent

caohdgege
caohdgege approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Jun 16, 2021
@funky-eyes funky-eyes changed the title fix TC SkyWalking topo calling node not gather bugfix: TC SkyWalking topo calling node not gather Jun 19, 2021
@funky-eyes funky-eyes requested a review from slievrly June 19, 2021 16:23
slievrly
slievrly approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 21e0264 into apache:develop Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@caohdgege caohdgege caohdgege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0 (1.5.1)
Development

Successfully merging this pull request may close these issues.

optimize：fix TC SkyWalking topo calling node not gather
7 participants
@zhaoyuguang @codecov-commenter @caohdgege @slievrly @wangliang181230 @xingfudeshi @funky-eyes