optimize: seata-distribution add apm-seata-skywalking #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slievrly
reviewed
Jun 22, 2021
| @@ -91,7 +91,7 @@ if exist %BASEDIR%/logs ( | |||
| md "%BASEDIR%/logs" | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
if "%SKYWALKING_ENABLE%"=="true"
There was a problem hiding this comment.
fix, but without Window environment, to verify correctness
Codecov Report
@@ Coverage Diff @@
## develop #3834 +/- ##
=============================================
- Coverage 40.72% 40.71% -0.02%
+ Complexity 2990 2989 -1
=============================================
Files 676 676
Lines 22608 22608
Branches 2805 2805
=============================================
- Hits 9207 9204 -3
- Misses 12554 12556 +2
- Partials 847 848 +1
|
…sw_dis_0 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
caohdgege
reviewed
Jun 23, 2021
| # plugin.springannotation.classname_match_regex=${SW_SPRINGANNOTATION_CLASSNAME_MATCH_REGEX:} | ||
|
|
||
| # If set to true, to identify the current node as Seata Server | ||
| plugin.seata.server=${SW_SEATA_SERVER:true} |
There was a problem hiding this comment.
the current config should be mark as unchangeable
zhaoyuguang
changed the title
zhaoyuguang
changed the title
…sw_dis_0 # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3830
package seata
export SKYWALKING_ENABLE=true
run seata-server.sh