Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimization apm-skwalking operation method to generate rules #3840

Merged
merged 5 commits into from
Jun 27, 2021

Conversation

zhaoyuguang
Copy link
Member

fixed #3839

@zhaoyuguang zhaoyuguang changed the title update The update SkyWalking version Jun 25, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please modify the changes/1.5.0.md & changes/en-us/1.5.0.md and modify the title

@zhaoyuguang zhaoyuguang changed the title The update SkyWalking version optimization apm-skwalking operation method to generate rules Jun 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2021

Codecov Report

Merging #3840 (d1c51c3) into develop (21e0264) will decrease coverage by 0.12%.
The diff coverage is 76.47%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3840      +/-   ##
=============================================
- Coverage      40.83%   40.71%   -0.13%     
- Complexity      2987     2989       +2     
=============================================
  Files            667      676       +9     
  Lines          22507    22608     +101     
  Branches        2799     2805       +6     
=============================================
+ Hits            9191     9204      +13     
- Misses         12469    12556      +87     
- Partials         847      848       +1     
Impacted Files Coverage Δ
...g/plugin/DefaultCoreDoGlobalCommitInterceptor.java 0.00% <0.00%> (ø)
...plugin/NettyRemotingClientSendSyncInterceptor.java 0.00% <0.00%> (ø)
...ng/plugin/RemotingProcessorProcessInterceptor.java 0.00% <0.00%> (ø)
...king/plugin/define/DefaultCoreInstrumentation.java 0.00% <ø> (ø)
...lugin/define/RemotingProcessorInstrumentation.java 0.00% <ø> (ø)
...apm/skywalking/plugin/common/SWSeataConstants.java 90.00% <100.00%> (ø)
...ata/apm/skywalking/plugin/common/SWSeataUtils.java 54.54% <100.00%> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...pm/skywalking/plugin/common/SeataPluginConfig.java 25.00% <0.00%> (ø)
... and 7 more

@zhaoyuguang
Copy link
Member Author

fixed, type of optimization

@caohdgege caohdgege changed the title optimization apm-skwalking operation method to generate rules optimize: optimization apm-skwalking operation method to generate rules Jun 27, 2021
@caohdgege caohdgege merged commit 0db08f5 into apache:develop Jun 27, 2021
@slievrly slievrly added this to the 1.5.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimization apm-skwalking operation method to generate rules
4 participants