optimize: ConcurrentHashMap.newKeySet replace ConcurrentSet #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionTemplate code
…tionTemplate code
Codecov Report
@@ Coverage Diff @@
## develop #3847 +/- ##
==========================================
Coverage 40.67% 40.67%
Complexity 2991 2991
==========================================
Files 676 676
Lines 22614 22614
Branches 2808 2808
==========================================
Hits 9199 9199
Misses 12564 12564
Partials 851 851
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.移除因set的使用在配置中心引入netty的强依赖关系；
2.ConcurrentSet will remove in Netty 4.2. need use {@link ConcurrentHashMap#newKeySet()} instead
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews