Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: invalid string concat #3849

Merged
merged 4 commits into from
Jul 2, 2021
Merged

optimize: invalid string concat #3849

merged 4 commits into from
Jul 2, 2021

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Jul 2, 2021

Ⅰ. Describe what this PR did

optimize: invalid string concat.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@e438c75). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3849   +/-   ##
==========================================
  Coverage           ?   40.60%           
  Complexity         ?     2991           
==========================================
  Files              ?      676           
  Lines              ?    22588           
  Branches           ?     2759           
==========================================
  Hits               ?     9171           
  Misses             ?    12541           
  Partials           ?      876           
Impacted Files Coverage Δ
...ta/core/rpc/netty/AbstractNettyRemotingServer.java 0.00% <0.00%> (ø)

@slievrly slievrly merged commit abda837 into apache:develop Jul 2, 2021
@slievrly slievrly added this to the 1.5.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants