-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support get configuration from environment #3869
Conversation
Signed-off-by: slievrly <slievrly@163.com>
config/seata-config-core/src/main/java/io/seata/config/Configuration.java
Show resolved
Hide resolved
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #3869 +/- ##
==========================================
Coverage 40.79% 40.80%
- Complexity 3058 3061 +3
==========================================
Files 682 681 -1
Lines 22878 22881 +3
Branches 2840 2840
==========================================
+ Hits 9334 9336 +2
+ Misses 12675 12673 -2
- Partials 869 872 +3
|
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
feature: support get configuration from environment
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews