Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support get configuration from environment #3869

Merged
merged 7 commits into from
Jul 23, 2021
Merged

feature: support get configuration from environment #3869

merged 7 commits into from
Jul 23, 2021

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

feature: support get configuration from environment

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
slievrly and others added 5 commits July 19, 2021 21:30
Signed-off-by: slievrly <slievrly@163.com>

# Conflicts:
#	changes/1.5.0.md
#	changes/en-us/1.5.0.md
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lj2018110133 lj2018110133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #3869 (87f5cf3) into develop (ba136f1) will increase coverage by 0.00%.
The diff coverage is 60.00%.

❗ Current head 87f5cf3 differs from pull request most recent head 851eb85. Consider uploading reports for the commit 851eb85 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3869   +/-   ##
==========================================
  Coverage      40.79%   40.80%           
- Complexity      3058     3061    +3     
==========================================
  Files            682      681    -1     
  Lines          22878    22881    +3     
  Branches        2840     2840           
==========================================
+ Hits            9334     9336    +2     
+ Misses         12675    12673    -2     
- Partials         869      872    +3     
Impacted Files Coverage Δ
...e/src/main/java/io/seata/config/Configuration.java 42.85% <33.33%> (-57.15%) ⬇️
...in/java/io/seata/config/AbstractConfiguration.java 65.62% <100.00%> (+3.55%) ⬆️
...c/main/java/io/seata/config/FileConfiguration.java 43.10% <100.00%> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
.../io/seata/core/rpc/netty/v1/ProtocolV1Decoder.java 0.00% <0.00%> (ø)
...ta/core/rpc/netty/AbstractNettyRemotingServer.java 0.00% <0.00%> (ø)
.../java/io/seata/core/exception/DecodeException.java
...n/java/io/seata/rm/datasource/DataSourceProxy.java 46.87% <0.00%> (+1.42%) ⬆️

@apache apache deleted a comment from lj2018110133 Jul 23, 2021
@slievrly slievrly merged commit d344a01 into apache:develop Jul 23, 2021
@slievrly slievrly added this to the 1.5.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants