Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: make seata-bom be the real Bill-Of-Material #3870

Merged
merged 4 commits into from
Jul 23, 2021

Conversation

JasonMing
Copy link
Contributor

Ⅰ. Describe what this PR did

Add all deployable modules with "jar" packaging to seata-bom's dependencyManagement.
All the users could import seata-bom to align the version of their seata dependencies.

Ⅱ. Does this pull request fix one issue?

fixes #3761

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@JasonMing
Copy link
Contributor Author

JasonMing commented Jul 16, 2021

There is two force-push for correcting the gpg sign issue, don't mind it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #3870 (850f1a6) into develop (a1ae790) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3870      +/-   ##
=============================================
- Coverage      40.80%   40.79%   -0.01%     
  Complexity      3057     3057              
=============================================
  Files            681      681              
  Lines          22872    22872              
  Branches        2839     2839              
=============================================
- Hits            9333     9331       -2     
- Misses         12669    12671       +2     
  Partials         870      870              
Impacted Files Coverage Δ
...c/main/java/io/seata/config/FileConfiguration.java 43.10% <0.00%> (-1.15%) ⬇️

@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Jul 16, 2021
@wangliang181230
Copy link
Contributor

The maven-javadoc-plugin is not required for the seata-bom.

@JasonMing
Copy link
Contributor Author

JasonMing commented Jul 17, 2021

The maven-javadoc-plugin is not required for the seata-bom.

ok, I'll remove it

@slievrly slievrly added the first-time contributor first-time contributor label Jul 20, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 merged commit 5276c98 into apache:develop Jul 23, 2021
@JasonMing JasonMing deleted the feature/bom branch July 23, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inccorect BOM definition
4 participants