Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: contributing cn #3880

Merged
merged 18 commits into from
Aug 17, 2021
Merged

docs: contributing cn #3880

merged 18 commits into from
Aug 17, 2021

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Jul 19, 2021

Ⅰ. Describe what this PR did

feature contribuint cn doc.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #3880 (53b5ee0) into develop (e2e5fa6) will increase coverage by 0.35%.
The diff coverage is n/a.

❗ Current head 53b5ee0 differs from pull request most recent head 9ee011b. Consider uploading reports for the commit 9ee011b to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3880      +/-   ##
=============================================
+ Coverage      40.38%   40.73%   +0.35%     
  Complexity      3070     3070              
=============================================
  Files            685      682       -3     
  Lines          23194    23001     -193     
  Branches        2869     2867       -2     
=============================================
+ Hits            9366     9370       +4     
+ Misses         12958    12754     -204     
- Partials         870      877       +7     
Impacted Files Coverage Δ
...va/io/seata/rm/datasource/exec/DeleteExecutor.java 80.00% <0.00%> (-3.34%) ⬇️
.../seata/rm/datasource/exec/MultiDeleteExecutor.java 91.42% <0.00%> (-2.69%) ⬇️
.../java/io/seata/sqlparser/druid/BaseRecognizer.java 90.90% <0.00%> (-1.40%) ⬇️
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 75.40% <0.00%> (-1.26%) ⬇️
...c/main/java/io/seata/config/FileConfiguration.java 43.10% <0.00%> (-1.15%) ⬇️
.../seata/rm/datasource/exec/MultiUpdateExecutor.java 76.25% <0.00%> (-0.97%) ⬇️
.../rm/datasource/exec/BaseTransactionalExecutor.java 56.02% <0.00%> (-0.27%) ⬇️
server/src/main/java/io/seata/server/Server.java 0.00% <0.00%> (ø)
...in/java/io/seata/server/session/SessionHolder.java 0.00% <0.00%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 0.00% <0.00%> (ø)
... and 21 more

slievrly
slievrly previously approved these changes Jul 19, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly self-requested a review July 19, 2021 06:09
CONTRIBUTING_CN.md Outdated Show resolved Hide resolved
@slievrly slievrly self-requested a review July 19, 2021 06:10
CONTRIBUTING_CN.md Outdated Show resolved Hide resolved
CONTRIBUTING_CN.md Outdated Show resolved Hide resolved
CONTRIBUTING_CN.md Outdated Show resolved Hide resolved
CONTRIBUTING_CN.md Outdated Show resolved Hide resolved
Copy link

@xilou31 xilou31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING_CN.md Outdated Show resolved Hide resolved
CONTRIBUTING_CN.md Outdated Show resolved Hide resolved
CONTRIBUTING_CN.md Outdated Show resolved Hide resolved
CONTRIBUTING_CN.md Outdated Show resolved Hide resolved
@caohdgege
Copy link
Contributor

英文版和中文版的可以互相加个跳转链接

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Aug 17, 2021
@funky-eyes funky-eyes merged commit 647e846 into apache:develop Aug 17, 2021
UmmizzZ pushed a commit to UmmizzZ/seata that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants