Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix getConfig with different default value return the first #3881

Merged
merged 6 commits into from
Jul 20, 2021
Merged

bugfix: fix getConfig with different default value return the first #3881

merged 6 commits into from
Jul 20, 2021

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix getConfig with different value return the first

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly changed the title bugfix: fix getConfig with different value return the first bugfix: fix getConfig with different default value return the first Jul 19, 2021
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #3881 (8000513) into develop (273d717) will increase coverage by 0.04%.
The diff coverage is 84.21%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3881      +/-   ##
=============================================
+ Coverage      40.75%   40.79%   +0.04%     
- Complexity      3052     3057       +5     
=============================================
  Files            681      681              
  Lines          22853    22872      +19     
  Branches        2842     2839       -3     
=============================================
+ Hits            9313     9331      +18     
- Misses         12669    12671       +2     
+ Partials         871      870       -1     
Impacted Files Coverage Δ
.../main/java/io/seata/config/ConfigurationCache.java 71.42% <84.21%> (+4.76%) ⬆️
...in/java/io/seata/config/AbstractConfiguration.java 62.06% <0.00%> (+3.44%) ⬆️

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added the module/config config module label Jul 20, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit a1ae790 into apache:develop Jul 20, 2021
@slievrly slievrly added this to the 1.5.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/config config module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants