Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: only the inserted fields are checked #3890

Merged
merged 8 commits into from
Jul 23, 2021

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Jul 21, 2021

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3891

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #3890 (5ec0650) into develop (d344a01) will increase coverage by 0.00%.
The diff coverage is 6.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3890   +/-   ##
==========================================
  Coverage      40.79%   40.79%           
- Complexity      3059     3061    +2     
==========================================
  Files            682      682           
  Lines          22887    22896    +9     
  Branches        2842     2844    +2     
==========================================
+ Hits            9336     9340    +4     
- Misses         12679    12685    +6     
+ Partials         872      871    -1     
Impacted Files Coverage Δ
.../rm/datasource/exec/BaseTransactionalExecutor.java 56.02% <6.25%> (-3.07%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jul 21, 2021
@funky-eyes funky-eyes requested a review from slievrly July 22, 2021 14:56
jsbxyyx
jsbxyyx previously approved these changes Jul 23, 2021
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于MySQL开启CURRENT_TIMESTAMP 特性,导致分布式事务失败的问题
4 participants