Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize decode exception #3895

Merged
merged 4 commits into from
Jul 23, 2021
Merged

optimize: optimize decode exception #3895

merged 4 commits into from
Jul 23, 2021

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jul 22, 2021

Ⅰ. Describe what this PR did

optimize: optimize decode exception

fix #1700 #2451 #2555 #2570 #2677 #2729 #3648

Ⅱ. Does this pull request fix one issue?

image

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

telnet 127.0.0.1 8091

input "xxxxxxxxxxxxxxxxxxxxxx"

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #3895 (a659ea3) into develop (3a9f9d0) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3895      +/-   ##
=============================================
- Coverage      40.79%   40.78%   -0.01%     
  Complexity      3057     3057              
=============================================
  Files            681      682       +1     
  Lines          22874    22878       +4     
  Branches        2840     2840              
=============================================
  Hits            9331     9331              
- Misses         12673    12677       +4     
  Partials         870      870              
Impacted Files Coverage Δ
.../java/io/seata/core/exception/DecodeException.java 0.00% <0.00%> (ø)
...ta/core/rpc/netty/AbstractNettyRemotingServer.java 0.00% <0.00%> (ø)
.../io/seata/core/rpc/netty/v1/ProtocolV1Decoder.java 0.00% <0.00%> (ø)

Signed-off-by: slievrly <slievrly@163.com>
@funky-eyes funky-eyes added this to the 1.5.0 milestone Jul 22, 2021
@lj2018110133
Copy link
Contributor

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lj2018110133 lj2018110133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit ba136f1 into apache:develop Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use spring boot admin to report netty error
4 participants