Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix LocalDataTime type in FastjsonUndoLogParser can't be rollback #3897

Merged
merged 3 commits into from
Aug 20, 2021

Conversation

lvekee
Copy link
Contributor

@lvekee lvekee commented Jul 24, 2021

Ⅰ. Describe what this PR did

Solve the bug of DataTime type in FastjsonUndoLogParser, resulting in the transaction cannot be rolled back

Ⅱ. Does this pull request fix one issue?

fixes #3866.

@caohdgege caohdgege requested a review from jsbxyyx July 24, 2021 12:37
@caohdgege caohdgege added the mode: AT AT transaction mode label Jul 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2021

Codecov Report

Merging #3897 (ca387a8) into develop (4dd9f69) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3897      +/-   ##
=============================================
- Coverage      40.37%   40.36%   -0.02%     
  Complexity      3072     3072              
=============================================
  Files            686      686              
  Lines          23198    23200       +2     
  Branches        2868     2869       +1     
=============================================
- Hits            9366     9364       -2     
- Misses         12962    12966       +4     
  Partials         870      870              
Impacted Files Coverage Δ
.../java/io/seata/rm/datasource/DataCompareUtils.java 72.41% <0.00%> (-1.71%) ⬇️
...c/main/java/io/seata/config/FileConfiguration.java 43.10% <0.00%> (-1.15%) ⬇️

@lvekee lvekee changed the title bugfix:FastjsonUndoLogParser关于datatime类型的bug导致事务不能回滚 bugfix:Solve the bug of DataTime type in FastjsonUndoLogParser, resulting in the transaction cannot be rolled back Jul 24, 2021
@slievrly slievrly changed the title bugfix:Solve the bug of DataTime type in FastjsonUndoLogParser, resulting in the transaction cannot be rolled back bugfix: fix LocalDataTime type in FastjsonUndoLogParser can't be rollback Aug 20, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.5.0 milestone Aug 20, 2021
@slievrly slievrly merged commit cfa2b24 into apache:develop Aug 20, 2021
UmmizzZ pushed a commit to UmmizzZ/seata that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: AT AT transaction mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastjsonUndoLogParser 关于 datatime 类型的bug 导致事务不能回滚
5 participants