Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: optimize nacos-config.sh to support ash #3905

Merged
merged 8 commits into from
Jul 31, 2021
Merged

optimize: optimize nacos-config.sh to support ash #3905

merged 8 commits into from
Jul 31, 2021

Conversation

lvekee
Copy link
Contributor

@lvekee lvekee commented Jul 25, 2021 •
edited

Ⅰ. Describe what this PR did

optimize nacos-config.sh to support ash

Ⅱ. Does this pull request fix one issue?

fixes #3892 .

@lvekee lvekee changed the title refactor:Refactoring nacos-config.sh to support ash optimize:Optimize nacos-config.sh to support ash Jul 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021 •
edited

Codecov Report

Merging #3905 (a29afb2) into develop (8ee245b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3905      +/-   ##
=============================================
- Coverage      40.72%   40.70%   -0.03%     
+ Complexity      3060     3057       -3     
=============================================
  Files            682      682              
  Lines          22925    22925              
  Branches        2850     2850              
=============================================
- Hits            9337     9332       -5     
- Misses         12716    12721       +5     
  Partials         872      872
Impacted Files Coverage Δ
...source/AbstractDataSourceCacheResourceManager.java 42.85% <0.00%> (-42.86%) ⬇️
...ource/sql/struct/cache/AbstractTableMetaCache.java 72.41% <0.00%> (-17.25%) ⬇️
.../main/java/io/seata/rm/BaseDataSourceResource.java 26.41% <0.00%> (-3.78%) ⬇️
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.76% <0.00%> (+1.34%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

xjlgod
xjlgod approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@xjlgod xjlgod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it, the sh can work.

caohdgege
caohdgege approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

funky-eyes
funky-eyes approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caohdgege caohdgege changed the title optimize:Optimize nacos-config.sh to support ash optimize: optimize nacos-config.sh to support ash Jul 31, 2021
@caohdgege caohdgege merged commit 65066d2 into apache:develop Jul 31, 2021
@slievrly slievrly added this to the 1.5.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

@caohdgege caohdgege caohdgege approved these changes

@xjlgod xjlgod xjlgod approved these changes

Assignees
No one assigned
Labels
module/config config module type: optimize
Projects
None yet
Milestone
1.5.0 (1.5.1)
Development

Successfully merging this pull request may close these issues.

nacos-config.sh support ash shell
6 participants
@lvekee @codecov-commenter @funky-eyes @caohdgege @xjlgod @slievrly