Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support SPI unload #3906

Merged
merged 1 commit into from
Jul 26, 2021
Merged

feature: support SPI unload #3906

merged 1 commit into from
Jul 26, 2021

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

feature: support SPI unload

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3906 (80e9e8c) into develop (9799ec1) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3906      +/-   ##
=============================================
- Coverage      40.78%   40.74%   -0.04%     
- Complexity      3060     3061       +1     
=============================================
  Files            682      682              
  Lines          22896    22925      +29     
  Branches        2844     2850       +6     
=============================================
+ Hits            9337     9340       +3     
- Misses         12687    12714      +27     
+ Partials         872      871       -1     
Impacted Files Coverage Δ
.../io/seata/common/loader/EnhancedServiceLoader.java 57.00% <0.00%> (-8.59%) ⬇️
...va/io/seata/common/loader/ExtensionDefinition.java 38.70% <0.00%> (-1.30%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 0750bd9 into apache:develop Jul 26, 2021
@slievrly slievrly added this to the 1.5.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants