Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize set server port #3907

Merged
merged 23 commits into from
Aug 25, 2021
Merged

optimize: optimize set server port #3907

merged 23 commits into from
Aug 25, 2021

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: optimize set server port

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #3907 (742a5c2) into develop (6b45e42) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head 742a5c2 differs from pull request most recent head 8b9a92a. Consider uploading reports for the commit 8b9a92a to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3907      +/-   ##
=============================================
- Coverage      40.30%   40.22%   -0.09%     
  Complexity      3070     3070              
=============================================
  Files            687      686       -1     
  Lines          23231    23280      +49     
  Branches        2868     2890      +22     
=============================================
  Hits            9364     9364              
- Misses         12997    13046      +49     
  Partials         870      870              
Impacted Files Coverage Δ
...ta/core/rpc/netty/AbstractNettyRemotingServer.java 0.00% <ø> (ø)
.../io/seata/core/rpc/netty/NettyServerBootstrap.java 0.00% <0.00%> (ø)
...src/main/java/io/seata/server/ParameterParser.java 0.00% <ø> (ø)
server/src/main/java/io/seata/server/Server.java 0.00% <ø> (ø)
...c/main/java/io/seata/server/ServerApplication.java 0.00% <0.00%> (ø)
...main/java/io/seata/server/env/ContainerHelper.java 0.00% <0.00%> (ø)
.../src/main/java/io/seata/server/env/PortHelper.java 0.00% <0.00%> (ø)
...o/seata/discovery/registry/RegistryHeartBeats.java
...ery/registry/consul/ConsulRegistryServiceImpl.java 1.76% <0.00%> (+0.06%) ⬆️
...covery/registry/etcd3/EtcdRegistryServiceImpl.java 11.62% <0.00%> (+0.17%) ⬆️

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

话说logback里有个默认的9091端口改一下?

slievrly and others added 7 commits July 27, 2021 18:29
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>

# Conflicts:
#	server/src/test/java/io/seata/server/lock/redis/RedisLockManagerTest.java
#	server/src/test/java/io/seata/server/session/redis/RedisSessionManagerTest.java
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>

# Conflicts:
#	changes/1.5.0.md
#	changes/en-us/1.5.0.md
@slievrly slievrly added the module/server server module label Aug 13, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit ae2a4c8 into apache:develop Aug 25, 2021
@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Aug 30, 2021
UmmizzZ pushed a commit to UmmizzZ/seata that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants