Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize collectRowLocks method. #3909

Merged
merged 2 commits into from
Sep 14, 2021
Merged

optimize: optimize collectRowLocks method. #3909

merged 2 commits into from
Sep 14, 2021

Conversation

tian-qingzhao
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes
Copy link
Contributor

可以把源码中所有类似的地方都找到一并修改吗?

@tian-qingzhao
Copy link
Contributor Author

可以把源码中所有类似的地方都找到一并修改吗?

Sorry, this is all I can see so far. I will continue to submit if I see any more.

@funky-eyes
Copy link
Contributor

可以把源码中所有类似的地方都找到一并修改吗?

Sorry, this is all I can see so far. I will continue to submit if I see any more.

ok, we'll wait for you to add it to this pr

@funky-eyes funky-eyes added the Do Not Merge Do not merge into develop label Jul 27, 2021
@tian-qingzhao
Copy link
Contributor Author

可以把源码中所有类似的地方都找到一并修改吗?

Sorry, this is all I can see so far. I will continue to submit if I see any more.

ok, we'll wait for you to add it to this pr

可以把源码中所有类似的地方都找到一并修改吗?

Sorry, this is all I can see so far. I will continue to submit if I see any more.

ok, we'll wait for you to add it to this pr

I think we should merge the branches first and make sure that each branch only does one thing. No similar code has been found anywhere else.

@funky-eyes
Copy link
Contributor

可以把源码中所有类似的地方都找到一并修改吗?

Sorry, this is all I can see so far. I will continue to submit if I see any more.

ok, we'll wait for you to add it to this pr

可以把源码中所有类似的地方都找到一并修改吗?

Sorry, this is all I can see so far. I will continue to submit if I see any more.

ok, we'll wait for you to add it to this pr

I think we should merge the branches first and make sure that each branch only does one thing. No similar code has been found anywhere else.

I think it's the same thing

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021

Codecov Report

Merging #3909 (a59f006) into develop (8a4f5d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3909   +/-   ##
==========================================
  Coverage      49.39%   49.39%           
  Complexity      3726     3726           
==========================================
  Files            692      692           
  Lines          23435    23436    +1     
  Branches        2911     2911           
==========================================
+ Hits           11576    11577    +1     
  Misses         10693    10693           
  Partials        1166     1166           
Impacted Files Coverage Δ
...java/io/seata/server/lock/AbstractLockManager.java 62.90% <100.00%> (+0.60%) ⬆️

@slievrly slievrly added this to the 1.5.0 milestone Sep 14, 2021
@slievrly slievrly removed the Do Not Merge Do not merge into develop label Sep 14, 2021
@slievrly slievrly changed the title optimize collectRowLocks method. optimize: optimize collectRowLocks method. Sep 14, 2021
@slievrly slievrly merged commit 129c2f3 into apache:develop Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants