-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: determine whether the server in the register is alive #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Jul 29, 2021
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Jul 29, 2021
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #3916 +/- ##
=============================================
+ Coverage 40.70% 40.74% +0.03%
- Complexity 3057 3073 +16
=============================================
Files 682 682
Lines 22925 23002 +77
Branches 2850 2867 +17
=============================================
+ Hits 9332 9372 +40
- Misses 12721 12753 +32
- Partials 872 877 +5
|
funky-eyes
reviewed
Aug 2, 2021
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 4, 2021
discovery/seata-discovery-core/src/main/java/io/seata/discovery/registry/RegistryService.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 4, 2021
core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 4, 2021
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 4, 2021
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/TmNettyRemotingClient.java
Outdated
Show resolved
Hide resolved
discovery/seata-discovery-core/src/main/java/io/seata/discovery/registry/RegistryService.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 4, 2021
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Show resolved
Hide resolved
discovery/seata-discovery-core/src/main/java/io/seata/discovery/registry/RegistryService.java
Outdated
Show resolved
Hide resolved
funky-eyes
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pr做个登记
l81893521
reviewed
Aug 10, 2021
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
l81893521
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
determine whether the server in the register is alive
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews