Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: determine whether the server in the register is alive #3916

Merged
merged 23 commits into from
Aug 10, 2021

Conversation

lj2018110133
Copy link
Contributor

Ⅰ. Describe what this PR did

determine whether the server in the register is alive

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #3916 (ffaa5b2) into develop (65066d2) will increase coverage by 0.03%.
The diff coverage is 39.65%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3916      +/-   ##
=============================================
+ Coverage      40.70%   40.74%   +0.03%     
- Complexity      3057     3073      +16     
=============================================
  Files            682      682              
  Lines          22925    23002      +77     
  Branches        2850     2867      +17     
=============================================
+ Hits            9332     9372      +40     
- Misses         12721    12753      +32     
- Partials         872      877       +5     
Impacted Files Coverage Δ
...ta/core/rpc/netty/AbstractNettyRemotingClient.java 17.96% <0.00%> (ø)
...ta/discovery/registry/FileRegistryServiceImpl.java 0.00% <ø> (ø)
...a/io/seata/discovery/registry/RegistryService.java 0.00% <0.00%> (ø)
...eata/core/rpc/netty/NettyClientChannelManager.java 52.14% <38.77%> (-8.36%) ⬇️
...io/seata/core/rpc/netty/TmNettyRemotingClient.java 56.66% <66.66%> (+0.71%) ⬆️
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.56% <0.00%> (-0.20%) ⬇️
...main/java/io/seata/common/util/ReflectionUtil.java 65.43% <0.00%> (+5.71%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pr做个登记

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Aug 10, 2021
@funky-eyes funky-eyes merged commit 37e9efa into apache:develop Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants