bugfix: use system time and current folder to jstack #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3931 +/- ##
=============================================
- Coverage 40.76% 40.74% -0.02%
+ Complexity 3067 3066 -1
=============================================
Files 682 682
Lines 22948 22950 +2
Branches 2856 2856
=============================================
- Hits 9355 9352 -3
- Misses 12722 12726 +4
- Partials 871 872 +1
|
jsbxyyx
reviewed
Aug 6, 2021
| try { | ||
| Runtime.getRuntime().exec("jstack " + pid + " >d:/" + idx + ".log"); | ||
| Runtime.getRuntime().exec("jstack " + pid + " > " + idx + ".log"); |
There was a problem hiding this comment.
may be no permission, use current execute user home dir?
There was a problem hiding this comment.
may be no permission, use current execute user home dir?
I think this operation will dump the file to the folder of the running path?
There was a problem hiding this comment.
recommended to add logging record commands. view the stack information path from the log information.
|
rename pr title |
leizhiyuan
changed the title
slievrly
reviewed
Aug 8, 2021
There was a problem hiding this comment.
@leizhiyuan a small problem about code style, please fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
use System.currentTimeMillis() as id, and jstack dump to current folder.
Ⅱ. Does this pull request fix one issue?
fixes #3922
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews