-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support zstd compressor #3951
Conversation
bom/pom.xml
Outdated
@@ -372,6 +372,31 @@ | |||
<artifactId>seata-sqlparser-druid</artifactId> | |||
<version>${project.version}</version> | |||
</dependency> | |||
<dependency> | |||
<groupId>com.github.luben</groupId> | |||
<artifactId>zstd-jni</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bom挪到dependencies
Codecov Report
@@ Coverage Diff @@
## develop #3951 +/- ##
=============================================
- Coverage 40.30% 40.26% -0.05%
- Complexity 3070 3077 +7
=============================================
Files 687 689 +2
Lines 23231 23218 -13
Branches 2868 2818 -50
=============================================
- Hits 9364 9348 -16
+ Misses 12997 12975 -22
- Partials 870 895 +25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add artifactSet in maven-shade-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews