Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support zstd compressor #3951

Merged
merged 9 commits into from
Aug 25, 2021

Conversation

caohdgege
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

bom/pom.xml Outdated
@@ -372,6 +372,31 @@
<artifactId>seata-sqlparser-druid</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.github.luben</groupId>
<artifactId>zstd-jni</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bom挪到dependencies

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021

Codecov Report

Merging #3951 (ad2d41e) into develop (6b45e42) will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3951      +/-   ##
=============================================
- Coverage      40.30%   40.26%   -0.05%     
- Complexity      3070     3077       +7     
=============================================
  Files            687      689       +2     
  Lines          23231    23218      -13     
  Branches        2868     2818      -50     
=============================================
- Hits            9364     9348      -16     
+ Misses         12997    12975      -22     
- Partials         870      895      +25     
Impacted Files Coverage Δ
.../java/io/seata/core/compressor/CompressorType.java 0.00% <0.00%> (ø)
...rc/main/java/io/seata/compressor/zip/ZstdUtil.java 90.00% <90.00%> (ø)
...n/java/io/seata/compressor/zip/ZstdCompressor.java 100.00% <100.00%> (ø)
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) ⬇️
...otobuf/convertor/BranchReportRequestConvertor.java 90.90% <0.00%> (-9.10%) ⬇️
...obuf/convertor/BranchRollbackRequestConvertor.java 92.00% <0.00%> (-8.00%) ⬇️
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) ⬇️
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) ⬇️
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) ⬇️
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) ⬇️
... and 32 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add artifactSet in maven-shade-plugin

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimize: add zstd compressor support feature: support zstd compressor Aug 25, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit c6af409 into apache:develop Aug 25, 2021
@caohdgege caohdgege deleted the feature-add-Compressor branch August 25, 2021 10:30
@slievrly slievrly added this to the 1.5.0 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants