-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support brpc-java rpc XID propagation #3968
Conversation
add license done @slievrly |
请解决下ci错误 |
integration/brpc/src/test/java/io/seata/integration/brpc/dto/EchoResponse.java
Outdated
Show resolved
Hide resolved
...on/brpc/src/main/java/io/seata/integration/brpc/TransactionPropagationClientInterceptor.java
Outdated
Show resolved
Hide resolved
...on/brpc/src/main/java/io/seata/integration/brpc/TransactionPropagationServerInterceptor.java
Show resolved
Hide resolved
integration/brpc/src/test/java/io/seata/integration/brpc/dto/EchoRequest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #3968 +/- ##
=============================================
+ Coverage 48.49% 48.52% +0.02%
- Complexity 3821 3832 +11
=============================================
Files 726 728 +2
Lines 24410 24479 +69
Branches 3008 3025 +17
=============================================
+ Hits 11838 11878 +40
- Misses 11319 11333 +14
- Partials 1253 1268 +15
|
...on/brpc/src/main/java/io/seata/integration/brpc/TransactionPropagationClientInterceptor.java
Outdated
Show resolved
Hide resolved
@mengxzh any response here? |
...on/brpc/src/main/java/io/seata/integration/brpc/TransactionPropagationClientInterceptor.java
Outdated
Show resolved
Hide resolved
...on/brpc/src/main/java/io/seata/integration/brpc/TransactionPropagationClientInterceptor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM . 麻烦在changes文件夹中的两个1.5.0.md文件登记作者信息和pr信息
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
feature: support brpc-java rpc XID propagation
Ⅱ. Does this pull request fix one issue?
not yet
Ⅲ. Why don't you add test cases (unit test/integration test)?
already add unit case
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews