Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support brpc-java rpc XID propagation #3968

Merged
merged 21 commits into from
Jan 23, 2022
Merged

feature: support brpc-java rpc XID propagation #3968

merged 21 commits into from
Jan 23, 2022

Conversation

mengxzh
Copy link
Contributor

@mengxzh mengxzh commented Aug 20, 2021

Ⅰ. Describe what this PR did

feature: support brpc-java rpc XID propagation

Ⅱ. Does this pull request fix one issue?

not yet

Ⅲ. Why don't you add test cases (unit test/integration test)?

already add unit case

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly
Copy link
Member

@mengxzh
image

@mengxzh
Copy link
Contributor Author

mengxzh commented Aug 21, 2021

add license done @slievrly

@funky-eyes
Copy link
Contributor

image

@funky-eyes
Copy link
Contributor

请解决下ci错误

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #3968 (3e8f9b2) into develop (8df3ab0) will increase coverage by 0.02%.
The diff coverage is 56.66%.

❗ Current head 3e8f9b2 differs from pull request most recent head c19698d. Consider uploading reports for the commit c19698d to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3968      +/-   ##
=============================================
+ Coverage      48.49%   48.52%   +0.02%     
- Complexity      3821     3832      +11     
=============================================
  Files            726      728       +2     
  Lines          24410    24479      +69     
  Branches        3008     3025      +17     
=============================================
+ Hits           11838    11878      +40     
- Misses         11319    11333      +14     
- Partials        1253     1268      +15     
Impacted Files Coverage Δ
.../brpc/TransactionPropagationServerInterceptor.java 48.57% <48.57%> (ø)
.../brpc/TransactionPropagationClientInterceptor.java 68.00% <68.00%> (ø)
...n/java/io/seata/rm/datasource/DataSourceProxy.java 45.45% <0.00%> (-1.61%) ⬇️
.../main/java/io/seata/rm/datasource/ColumnUtils.java 86.59% <0.00%> (-1.04%) ⬇️
...c/main/java/io/seata/core/context/RootContext.java 48.27% <0.00%> (-0.88%) ⬇️
...java/io/seata/common/exception/RedisException.java 0.00% <0.00%> (ø)
...java/io/seata/common/exception/StoreException.java 100.00% <0.00%> (ø)
...a/io/seata/rm/tcc/exception/TCCFenceException.java 0.00% <0.00%> (ø)
...io/seata/common/exception/DataAccessException.java 100.00% <0.00%> (ø)
...java/io/seata/rm/datasource/ConnectionContext.java 74.35% <0.00%> (ø)
... and 4 more

@slievrly
Copy link
Member

slievrly commented Nov 8, 2021

@mengxzh any response here?

@funky-eyes funky-eyes added this to the 1.5.0 milestone Nov 17, 2021
@funky-eyes funky-eyes added first-time contributor first-time contributor module/integration integration module type: feature Category issues or prs related to feature request. labels Nov 17, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . 麻烦在changes文件夹中的两个1.5.0.md文件登记作者信息和pr信息

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 3993984 into apache:develop Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/integration integration module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants