Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix NPE cause by future timeout #3978

Merged
merged 2 commits into from
Aug 31, 2021
Merged

bugfix: fix NPE cause by future timeout #3978

merged 2 commits into from
Aug 31, 2021

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Aug 26, 2021

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: fix NPE cause by future timeout

Ⅱ. Does this pull request fix one issue?

fix #3961

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.5.0 milestone Aug 27, 2021
@slievrly slievrly added the module/tm tm module label Aug 30, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #3978 (c2fd220) into develop (b0d346a) will increase coverage by 0.00%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #3978   +/-   ##
==========================================
  Coverage      40.15%   40.15%           
- Complexity      3077     3080    +3     
==========================================
  Files            690      690           
  Lines          23352    23357    +5     
  Branches        2891     2891           
==========================================
+ Hits            9376     9379    +3     
- Misses         13106    13108    +2     
  Partials         870      870           
Impacted Files Coverage Δ
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.28% <0.00%> (-0.29%) ⬇️
...ain/java/io/seata/core/protocol/MessageFuture.java 76.92% <33.33%> (-6.42%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

@funky-eyes funky-eyes merged commit 17b90c4 into apache:develop Aug 31, 2021
UmmizzZ pushed a commit to UmmizzZ/seata that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/tm tm module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata空指针
4 participants