optimize: optimize service port priority #3981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # server/src/test/java/io/seata/server/lock/redis/RedisLockManagerTest.java # server/src/test/java/io/seata/server/session/redis/RedisSessionManagerTest.java
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #3981 +/- ##
=============================================
- Coverage 40.21% 40.16% -0.05%
Complexity 3078 3078
=============================================
Files 689 690 +1
Lines 23323 23352 +29
Branches 2887 2891 +4
=============================================
Hits 9379 9379
- Misses 13075 13104 +29
Partials 869 869
|
server/src/main/java/io/seata/server/ServerApplicationRunListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/ServerApplicationRunListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
funky-eyes
reviewed
Aug 27, 2021
server/src/main/java/io/seata/server/ServerApplicationRunListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/ServerApplicationRunListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: slievrly <slievrly@163.com>
UmmizzZ
pushed a commit
to UmmizzZ/seata
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize service port priority
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
vm:
-Dserver.servicePort=9999
startup program arg:
-p 7890
env:
SEATA_PORT=45091
yml:
server:
service-port: 8091
yml:
server:
port: 7091 // offset + 1000
Ⅴ. Special notes for reviews