fixbug: fix Nacos user not found when password has special characters #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
type: bug
|
标题按照规范，英文，bugfix: 开头 补充pr信息及作者到changes文件夹的1.5.0的2个md文件中 |
elrond-g
changed the title
|
抱歉，已修改 |
funky-eyes
changed the title
funky-eyes
changed the title
funky-eyes
reviewed
Aug 30, 2021
Codecov Report
@@ Coverage Diff @@
## develop #3988 +/- ##
==========================================
Coverage 40.15% 40.15%
Complexity 3078 3078
==========================================
Files 690 690
Lines 23357 23357
Branches 2892 2892
==========================================
Hits 9379 9379
Misses 13108 13108
Partials 870 870 |
UmmizzZ
pushed a commit
to UmmizzZ/seata
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Nacos's Version 29ba11e has url encoded the password, so the password will be changed when it has special charaters. But at the Version 164ad31, nacos revert the change. So it need to update Nacos Version for fix the bug.
Ⅱ. Does this pull request fix one issue?
With nacos's issue : alibaba/nacos#3992
Ⅲ. Why don't you add test cases (unit test/integration test)?
The case shoud found on Nacos's project.
Ⅳ. Describe how to verify it
Use password has special charaters, e.g. "elrond%123", "user@12345"
Ⅴ. Special notes for reviews