-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: disable listening in the FileConfiguration center in Springboot #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
changed the title
optimize: disable listening in the File configuration center in Sprin…
optimize: disable listening in the File configuration center in Springboot
Aug 30, 2021
funky-eyes
changed the title
optimize: disable listening in the File configuration center in Springboot
optimize: disable listening in the FileConfiguration center in Springboot
Aug 30, 2021
slievrly
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangliang181230
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pls modify the |
Codecov Report
@@ Coverage Diff @@
## develop #3991 +/- ##
=============================================
+ Coverage 40.15% 40.23% +0.07%
- Complexity 3078 3082 +4
=============================================
Files 690 690
Lines 23357 23362 +5
Branches 2892 2893 +1
=============================================
+ Hits 9379 9399 +20
+ Misses 13108 13090 -18
- Partials 870 873 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
springboot中的file已经被SpringBootConfigurationProvider代理,不应该开启其file的listener线程,如果开启,springboot容器关闭后,监听线程依旧在运行,导致出现一堆org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext@79c4715d has been closed already 的异常,如果是因为用户自己的业务bug导致springboot容器无法启动,也会出现下述异常,导致用户认为是seata的bug
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews